From: Eric Blake <eblake@redhat.com>
To: Amos Kong <akong@redhat.com>,
lcapitulino@redhat.com, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, armbru@redhat.com, mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v4 2/3] qapi: add const prefix to 'char *' insider c_type()
Date: Mon, 12 May 2014 20:59:51 -0600 [thread overview]
Message-ID: <53718AA7.5030502@redhat.com> (raw)
In-Reply-To: <1399511680-12811-3-git-send-email-akong@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 620 bytes --]
On 05/07/2014 07:14 PM, Amos Kong wrote:
> It's ugly to add const prefix for parameter type by a if statement
s/a if/an if/
> outsider c_type(). This patch adds a parameter to do it.
s/outsider/outside/
>
> Signed-off-by: Amos Kong <akong@redhat.com>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> ---
> scripts/qapi-commands.py | 4 +---
> scripts/qapi.py | 4 +++-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-05-13 3:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 1:14 [Qemu-devel] [PATCH v4 0/3] qapi: fix coding style in generated code Amos Kong
2014-05-08 1:14 ` [Qemu-devel] [PATCH v4 1/3] qapi: fix coding style in parameters list Amos Kong
2014-05-13 2:57 ` Eric Blake
2014-05-21 2:08 ` Amos Kong
2014-05-08 1:14 ` [Qemu-devel] [PATCH v4 2/3] qapi: add const prefix to 'char *' insider c_type() Amos Kong
2014-05-13 2:59 ` Eric Blake [this message]
2014-05-08 1:14 ` [Qemu-devel] [PATCH v4 3/3] qapi: Suppress unwanted space between type and identifier Amos Kong
2014-05-15 19:36 ` Eric Blake
2014-05-15 19:05 ` [Qemu-devel] [PATCH v4 0/3] qapi: fix coding style in generated code Luiz Capitulino
2014-05-16 10:56 ` Paolo Bonzini
2014-05-16 14:19 ` Luiz Capitulino
2014-05-22 11:57 ` Amos Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53718AA7.5030502@redhat.com \
--to=eblake@redhat.com \
--cc=akong@redhat.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).