From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39224) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wk2wh-0002Fg-Mp for qemu-devel@nongnu.org; Mon, 12 May 2014 23:00:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wk2wd-0003a6-9K for qemu-devel@nongnu.org; Mon, 12 May 2014 22:59:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wk2wd-0003a2-0d for qemu-devel@nongnu.org; Mon, 12 May 2014 22:59:55 -0400 Message-ID: <53718AA7.5030502@redhat.com> Date: Mon, 12 May 2014 20:59:51 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399511680-12811-1-git-send-email-akong@redhat.com> <1399511680-12811-3-git-send-email-akong@redhat.com> In-Reply-To: <1399511680-12811-3-git-send-email-akong@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="T9QNF5m1iGJIfl3EpBlLmmKRS5HW4BWj0" Subject: Re: [Qemu-devel] [PATCH v4 2/3] qapi: add const prefix to 'char *' insider c_type() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong , lcapitulino@redhat.com, qemu-devel@nongnu.org Cc: pbonzini@redhat.com, armbru@redhat.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --T9QNF5m1iGJIfl3EpBlLmmKRS5HW4BWj0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/07/2014 07:14 PM, Amos Kong wrote: > It's ugly to add const prefix for parameter type by a if statement s/a if/an if/ > outsider c_type(). This patch adds a parameter to do it. s/outsider/outside/ >=20 > Signed-off-by: Amos Kong > Suggested-by: Markus Armbruster > --- > scripts/qapi-commands.py | 4 +--- > scripts/qapi.py | 4 +++- > 2 files changed, 4 insertions(+), 4 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --T9QNF5m1iGJIfl3EpBlLmmKRS5HW4BWj0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTcYqnAAoJEKeha0olJ0NqVZsIAKtFZvcP/v6hjzAeb1LGOi8P IRyJNWCRbxeAqihke+pOFA1kjhywIZz5tf8x3P/GSAR9tAHa2vqBDUysbvh3aEmG 1lr0R/yY8ZG00iLry7Ww7CD6iMS2I9ZbXFdABSylky3RwJyLjvwR/cStrrWAO3gY rgMbwHEuZ2Y3Tl22QH39GKb0whQnN8AGmLKLxaiMTM5tZ7+wAdTinJt0nQwgRdvn CIllsc9RrBb8DFRfUFRoE6D3jY+Uob3W337y2LSqasXPfnU8Ixf8IOgHWdVGDi7c rqtKeb49Ptd5+5IvTpf5NhCHbRxezjEtF+TG1jkk1SKhDlhAGdJOL+4WEo4PHTw= =k4v1 -----END PGP SIGNATURE----- --T9QNF5m1iGJIfl3EpBlLmmKRS5HW4BWj0--