From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wk6b8-0005gf-B0 for qemu-devel@nongnu.org; Tue, 13 May 2014 02:54:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wk6b0-0006ST-RI for qemu-devel@nongnu.org; Tue, 13 May 2014 02:53:58 -0400 Received: from cantor2.suse.de ([195.135.220.15]:42760 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wk6b0-0006SP-Ky for qemu-devel@nongnu.org; Tue, 13 May 2014 02:53:50 -0400 Message-ID: <5371C17C.20004@suse.de> Date: Tue, 13 May 2014 08:53:48 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1399565391-27833-1-git-send-email-pbonzini@redhat.com> <1399565391-27833-9-git-send-email-pbonzini@redhat.com> In-Reply-To: <1399565391-27833-9-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH 08/11] softmmu: make do_unaligned_access extern List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, rth@twiddle.net Am 08.05.2014 18:09, schrieb Paolo Bonzini: > We will reference it from more files in the next patch. >=20 > Signed-off-by: Paolo Bonzini > --- > target-alpha/cpu.h | 3 +++ > target-alpha/mem_helper.c | 4 ++-- > target-mips/cpu.h | 3 +++ > target-mips/op_helper.c | 8 ++------ > target-sparc/cpu.h | 4 ++++ > target-sparc/ldst_helper.c | 9 +++------ > target-xtensa/cpu.h | 3 +++ > target-xtensa/op_helper.c | 5 +---- > 8 files changed, 21 insertions(+), 18 deletions(-) >=20 > diff --git a/target-alpha/cpu.h b/target-alpha/cpu.h > index d9b861f..242068f 100644 > --- a/target-alpha/cpu.h > +++ b/target-alpha/cpu.h > @@ -498,6 +498,9 @@ static inline void cpu_get_tb_cpu_state(CPUAlphaSta= te *env, target_ulong *pc, > *pflags =3D flags; > } > =20 > +void do_unaligned_access(CPUAlphaState *env, target_ulong addr, > + int is_write, int is_user, uintptr_t retaddr)= ; > + > #include "exec/exec-all.h" > =20 > #endif /* !defined (__CPU_ALPHA_H__) */ [snip] Have you considered turning this into CPUClass hooks instead, as done with do_unassigned_access? Before your patch, this was a static function used only by softmmu_template.h - making it global is not exactly helping with multi-target support. Any solution to remedy regressions appreciated. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg