From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53367) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wk6p6-0001dJ-LD for qemu-devel@nongnu.org; Tue, 13 May 2014 03:08:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wk6ox-0002Q3-Ki for qemu-devel@nongnu.org; Tue, 13 May 2014 03:08:24 -0400 Received: from mail-ee0-x229.google.com ([2a00:1450:4013:c00::229]:32877) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wk6ox-0002Py-Ex for qemu-devel@nongnu.org; Tue, 13 May 2014 03:08:15 -0400 Received: by mail-ee0-f41.google.com with SMTP id t10so50297eei.0 for ; Tue, 13 May 2014 00:08:14 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5371C4DA.1020700@redhat.com> Date: Tue, 13 May 2014 09:08:10 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1399565391-27833-1-git-send-email-pbonzini@redhat.com> <1399565391-27833-9-git-send-email-pbonzini@redhat.com> <5371C17C.20004@suse.de> In-Reply-To: <5371C17C.20004@suse.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC PATCH 08/11] softmmu: make do_unaligned_access extern List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, rth@twiddle.net Il 13/05/2014 08:53, Andreas Färber ha scritto: >> > +void do_unaligned_access(CPUAlphaState *env, target_ulong addr, >> > + int is_write, int is_user, uintptr_t retaddr); >> > + >> > #include "exec/exec-all.h" >> > >> > #endif /* !defined (__CPU_ALPHA_H__) */ > [snip] > > Have you considered turning this into CPUClass hooks instead, as done > with do_unassigned_access? > > Before your patch, this was a static function used only by > softmmu_template.h - making it global is not exactly helping with > multi-target support. Any solution to remedy regressions appreciated. Good idea! Paolo