Re: [Qemu-devel] [RFC PATCH 11/11] softmmu: move all load/store functions to cpu_ldst.h

[Paolo Bonzini <pbonzini@redhat.com>]

Il 13/05/2014 09:13, Andreas Färber ha scritto:
> Am 08.05.2014 18:09, schrieb Paolo Bonzini:
>> Unify pieces of cpu-all.h, exec-all.h, softmmu_exec.h and tcg/tcg.h
>> into a single new header file with all helpers.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>  include/exec/cpu-all.h                             | 119 -------
>>  include/exec/cpu_ldst.h                            | 369 ++++++++++++++++++++-
>>  .../exec/{softmmu_header.h => cpu_ldst_template.h} |   2 +-
>>  include/exec/exec-all.h                            |  25 --
>>  include/exec/softmmu_exec.h                        | 216 ------------
>>  tcg/tcg.h                                          |  13 -
>>  6 files changed, 368 insertions(+), 376 deletions(-)
>>  rename include/exec/{softmmu_header.h => cpu_ldst_template.h} (98%)
>>  delete mode 100644 include/exec/softmmu_exec.h
>
> Seems like a nice cleanup,
>
> Acked-by: Andreas Färber <afaerber@suse.de>
>
> Will rth be handling this along with the backend conversions mentioned
> in the cover letter?

I guess so, in the meanwhile I'll send out the ld_raw->ld_p conversion 
separately, and the v2 of do_unaligned_access conversion for you to review.

Paolo