From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wk7Cd-0007hv-Fi for qemu-devel@nongnu.org; Tue, 13 May 2014 03:32:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wk7CX-0001Yd-R7 for qemu-devel@nongnu.org; Tue, 13 May 2014 03:32:43 -0400 Received: from mail-ee0-x229.google.com ([2a00:1450:4013:c00::229]:59334) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wk7CX-0001YV-KM for qemu-devel@nongnu.org; Tue, 13 May 2014 03:32:37 -0400 Received: by mail-ee0-f41.google.com with SMTP id t10so72505eei.28 for ; Tue, 13 May 2014 00:32:36 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5371CA90.4000904@redhat.com> Date: Tue, 13 May 2014 09:32:32 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1399565391-27833-1-git-send-email-pbonzini@redhat.com> <1399565391-27833-12-git-send-email-pbonzini@redhat.com> <5371C616.3000003@suse.de> In-Reply-To: <5371C616.3000003@suse.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC PATCH 11/11] softmmu: move all load/store functions to cpu_ldst.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, rth@twiddle.net Il 13/05/2014 09:13, Andreas Färber ha scritto: > Am 08.05.2014 18:09, schrieb Paolo Bonzini: >> Unify pieces of cpu-all.h, exec-all.h, softmmu_exec.h and tcg/tcg.h >> into a single new header file with all helpers. >> >> Signed-off-by: Paolo Bonzini >> --- >> include/exec/cpu-all.h | 119 ------- >> include/exec/cpu_ldst.h | 369 ++++++++++++++++++++- >> .../exec/{softmmu_header.h => cpu_ldst_template.h} | 2 +- >> include/exec/exec-all.h | 25 -- >> include/exec/softmmu_exec.h | 216 ------------ >> tcg/tcg.h | 13 - >> 6 files changed, 368 insertions(+), 376 deletions(-) >> rename include/exec/{softmmu_header.h => cpu_ldst_template.h} (98%) >> delete mode 100644 include/exec/softmmu_exec.h > > Seems like a nice cleanup, > > Acked-by: Andreas Färber > > Will rth be handling this along with the backend conversions mentioned > in the cover letter? I guess so, in the meanwhile I'll send out the ld_raw->ld_p conversion separately, and the v2 of do_unaligned_access conversion for you to review. Paolo