From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wk8fw-0007b2-KT for qemu-devel@nongnu.org; Tue, 13 May 2014 05:07:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wk8fn-00070Z-JR for qemu-devel@nongnu.org; Tue, 13 May 2014 05:07:04 -0400 Received: from mail-ee0-x22f.google.com ([2a00:1450:4013:c00::22f]:42768) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wk8fn-00070P-2i for qemu-devel@nongnu.org; Tue, 13 May 2014 05:06:55 -0400 Received: by mail-ee0-f47.google.com with SMTP id c13so168291eek.20 for ; Tue, 13 May 2014 02:06:54 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5371E0AB.9010509@redhat.com> Date: Tue, 13 May 2014 11:06:51 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1399947893-25843-1-git-send-email-famz@redhat.com> <5371C495.7090809@redhat.com> <20140513071314.GB26360@T430.nay.redhat.com> In-Reply-To: <20140513071314.GB26360@T430.nay.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio-blk: Allow config-wce in dataplane List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, Stefan Hajnoczi Il 13/05/2014 09:13, Fam Zheng ha scritto: > On Tue, 05/13 09:07, Paolo Bonzini wrote: >> Il 13/05/2014 04:24, Fam Zheng ha scritto: >>> Dataplane now uses block layer. Protect bdrv_set_enable_write_cache with >>> aio_context_acquire and aio_context_release, so we can enable config-wce >>> to allow guest to modify the write cache online. >>> >>> Signed-off-by: Fam Zheng >>> >>> --- >>> This applies on top of Stefan's "dataplane: use QEMU block layer" >>> series. >>> >>> Signed-off-by: Fam Zheng >>> --- >>> hw/block/dataplane/virtio-blk.c | 6 ------ >>> hw/block/virtio-blk.c | 9 ++++++++- >>> 2 files changed, 8 insertions(+), 7 deletions(-) >>> >>> diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c >>> index 79fb612..46a6824 100644 >>> --- a/hw/block/dataplane/virtio-blk.c >>> +++ b/hw/block/dataplane/virtio-blk.c >>> @@ -332,12 +332,6 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *blk, >>> return; >>> } >>> >>> - if (blk->config_wce) { >>> - error_setg(errp, "device is incompatible with x-data-plane, " >>> - "use config-wce=off"); >>> - return; >>> - } >>> - >>> /* If dataplane is (re-)enabled while the guest is running there could be >>> * block jobs that can conflict. >>> */ >>> diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c >>> index 8a568e5..a031e56 100644 >>> --- a/hw/block/virtio-blk.c >>> +++ b/hw/block/virtio-blk.c >>> @@ -26,6 +26,7 @@ >>> # include >>> #endif >>> #include "hw/virtio/virtio-bus.h" >>> +#include "block/block_int.h" >> >> You shouldn't need to include this header file. Apart from this, the patch >> looks good. > > It's for bdrv_get_aio_context, otherwise it doesn't compile. I think it should be moved to block/block.h then. Stefan? Paolo