From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33239)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1WkCsH-000063-P7
	for qemu-devel@nongnu.org; Tue, 13 May 2014 09:36:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1WkCsC-0005qZ-BE
	for qemu-devel@nongnu.org; Tue, 13 May 2014 09:36:05 -0400
Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:57324 helo=mx01.kamp.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1WkCsC-0005qO-1D
	for qemu-devel@nongnu.org; Tue, 13 May 2014 09:36:00 -0400
Message-ID: <53721FB3.8020407@kamp.de>
Date: Tue, 13 May 2014 15:35:47 +0200
From: Peter Lieven <pl@kamp.de>
MIME-Version: 1.0
References: <1399813620-26668-1-git-send-email-mjt@msgid.tls.msk.ru>
	<53721867.5080404@kamp.de>
	<20140513131909.GA28745@T430.nay.redhat.com>
In-Reply-To: <20140513131909.GA28745@T430.nay.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] block/nfs: use per-object vars and make it
	modular
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org

On 13.05.2014 15:19, Fam Zheng wrote:
> On Tue, 05/13 15:04, Peter Lieven wrote:
>> On 11.05.2014 15:07, Michael Tokarev wrote:
>>> nfs block module uses libnfs and uses pkg-config to determine
>>> its build information.  Somehow it used only --libs, not --cflags,
>>> and added those libs into global $LIBS, instead of using per-object
>>> variable.
>> the missing cflags stuff was due to a bug in the libnfs.pc file.
>>
>> https://github.com/sahlberg/libnfs/commit/d47c989d886e5398143d43d3b6d25fdf7210cb11
>>
>> as there where no special flags I dropped it. this was before we realized
>> that we had to depend on a newer libnfs version anyway. thanks for spotting this.
>>
>>> Use both --libs and --cflags, use them as per-object variable,
>>> and finally make block/nfs.o to be modular.
>> can you explain the modular stuff?
> As what is possible with iscsi, gluster and curl now, with this change nfs.o is
> possible to be built to a separate block-nfs.so, if configured as
> --enable-modules, and loaded on program start.

Aah okay. This is something new and not something I did wrong when the patch was submitted?

Peter