From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkCvM-0001NP-UR for qemu-devel@nongnu.org; Tue, 13 May 2014 09:39:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkCvD-0006if-Fm for qemu-devel@nongnu.org; Tue, 13 May 2014 09:39:16 -0400 Received: from mail-qg0-x229.google.com ([2607:f8b0:400d:c04::229]:54113) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkCvD-0006iY-BL for qemu-devel@nongnu.org; Tue, 13 May 2014 09:39:07 -0400 Received: by mail-qg0-f41.google.com with SMTP id j5so397398qga.0 for ; Tue, 13 May 2014 06:39:06 -0700 (PDT) Sender: Richard Henderson Message-ID: <53722076.8070509@twiddle.net> Date: Tue, 13 May 2014 06:39:02 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1399938424-6703-1-git-send-email-rth@twiddle.net> <1399938424-6703-4-git-send-email-rth@twiddle.net> <874n0u826v.fsf@linaro.org> In-Reply-To: <874n0u826v.fsf@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 03/10] tcg: Push tcg-runtime routines into exec/helper-* List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QWxleCBCZW5uw6ll?= Cc: qemu-devel@nongnu.org, aurelien@aurel32.net On 05/13/2014 02:20 AM, Alex Bennée wrote: >> +#ifdef TARGET_LONG_BITS >> > +# if TARGET_LONG_BITS == 32 >> > +# define dh_alias_tl i32 >> > +# else >> > +# define dh_alias_tl i64 >> > +# endif > This bit seems unrelated to the rest of the patch. In fact I can't see > any uses of the dh_alias_* in the code base although there is some > dh_alias() glue magic that could be throwing me off. > It's the fact that the file gets used in tcg-runtime.c, a generic file compiled once that does not have TARGET_LONG_BITS defined at all. I take care to leave "tl" undefined as an alias so that we'd get a compile-time error if it were used. r~