From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36944) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkD0m-0004uI-OJ for qemu-devel@nongnu.org; Tue, 13 May 2014 09:45:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkD0d-0000Y3-O4 for qemu-devel@nongnu.org; Tue, 13 May 2014 09:44:52 -0400 Received: from mail-qg0-x22e.google.com ([2607:f8b0:400d:c04::22e]:34775) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkD0d-0000Xv-Km for qemu-devel@nongnu.org; Tue, 13 May 2014 09:44:43 -0400 Received: by mail-qg0-f46.google.com with SMTP id q108so391812qgd.19 for ; Tue, 13 May 2014 06:44:43 -0700 (PDT) Sender: Richard Henderson Message-ID: <537221C6.40000@twiddle.net> Date: Tue, 13 May 2014 06:44:38 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1399938424-6703-1-git-send-email-rth@twiddle.net> <1399938424-6703-5-git-send-email-rth@twiddle.net> <8738ge81k4.fsf@linaro.org> In-Reply-To: <8738ge81k4.fsf@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 04/10] tcg: Use helper-gen.h in tcg-op.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QWxleCBCZW5uw6ll?= Cc: qemu-devel@nongnu.org, aurelien@aurel32.net On 05/13/2014 02:34 AM, Alex Bennée wrote: > I'm having trouble figuring out what the sizemask stuff was trying to > achieve and if it's required/covered after the change. Is the final > helper now the one defined as? > > DEF(div_i32, 1, 2, 0, IMPL(TCG_TARGET_HAS_div_i32)) > > it's hard to follow the parameters of this compared to the target > helpers where the the argument sizes are a lot more explicit. The sizemask stuff is about encoding the argument types of the function. What you've quoted above is not the helper, but the TCG opcode. The helper is defined as DEF_HELPER_FLAGS_2(div_i32, TCG_CALL_NO_RWG_SE, s32, s32, s32) in the previous patch. r~