* [Qemu-devel] Build Broken?
@ 2014-05-13 14:17 Tom Musta
2014-05-13 15:34 ` Michael Tokarev
0 siblings, 1 reply; 6+ messages in thread
From: Tom Musta @ 2014-05-13 14:17 UTC (permalink / raw)
To: QEMU Developers
The current origin/master is not building for me:
LINK qemu-img
qemu-img.o: In function `add_format_to_seq':
/bghome/tmusta/powerisa/qemu/qemu/qemu-img.c:73: undefined reference to `g_sequence_lookup'
collect2: ld returned 1 exit status
make: *** [qemu-img] Error 1
Bisection points me to this:
> git bisect good
1a443c1b8b4314d365e82bddeb1de5b4b1c15fb3 is the first bad commit
commit 1a443c1b8b4314d365e82bddeb1de5b4b1c15fb3
Author: Mike Day <ncmike@ncultra.org>
Date: Mon May 5 12:53:34 2014 -0400
qemu-img: sort block formats in help message
The help message for qemu-img lists the supported block formats, of
which there are 27 as of version 2.0.50. The formats are printed in
the order of their driver's position in a linked list, which appears
random. This patch prints the formats in sorted order, making it
easier to read and to find a specific format in the list.
[Added suggestions from Fam Zheng <famz@redhat.com> to declare variables
at the top of the scope in help() and to omit explicit cast for void*
opaque.
--Stefan]
Signed-off-by: Mike Day <ncmike@ncultra.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
It appears that this code is dependent on glib.h function that is newer than one of my build systems
(RHEL 6 update 5, gcc version 4.4.7 20120313 (Red Hat 4.4.7-4))
Is this a known limitation? i.e. is QEMU 2.1 going to prereq a newer version of glib2?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] Build Broken?
2014-05-13 14:17 [Qemu-devel] Build Broken? Tom Musta
@ 2014-05-13 15:34 ` Michael Tokarev
2014-05-13 15:53 ` Cornelia Huck
2014-05-13 15:55 ` Peter Maydell
0 siblings, 2 replies; 6+ messages in thread
From: Michael Tokarev @ 2014-05-13 15:34 UTC (permalink / raw)
To: Tom Musta, QEMU Developers
13.05.2014 18:17, Tom Musta wrote:
> The current origin/master is not building for me:
>
> LINK qemu-img
> qemu-img.o: In function `add_format_to_seq':
> /bghome/tmusta/powerisa/qemu/qemu/qemu-img.c:73: undefined reference to `g_sequence_lookup'
> collect2: ld returned 1 exit status
> make: *** [qemu-img] Error 1
[]
> It appears that this code is dependent on glib.h function that is newer than one of my build systems
> (RHEL 6 update 5, gcc version 4.4.7 20120313 (Red Hat 4.4.7-4))
>
> Is this a known limitation? i.e. is QEMU 2.1 going to prereq a newer version of glib2?
If we're going to require more recent glib (g_sequence_lookup() first appeared in 2.26),
let's require at least 2.31 with the new threading primitives as well.
Thanks,
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] Build Broken?
2014-05-13 15:34 ` Michael Tokarev
@ 2014-05-13 15:53 ` Cornelia Huck
2014-05-13 15:55 ` Peter Maydell
1 sibling, 0 replies; 6+ messages in thread
From: Cornelia Huck @ 2014-05-13 15:53 UTC (permalink / raw)
To: Michael Tokarev; +Cc: Tom Musta, QEMU Developers
On Tue, 13 May 2014 19:34:53 +0400
Michael Tokarev <mjt@tls.msk.ru> wrote:
> 13.05.2014 18:17, Tom Musta wrote:
> > The current origin/master is not building for me:
> >
> > LINK qemu-img
> > qemu-img.o: In function `add_format_to_seq':
> > /bghome/tmusta/powerisa/qemu/qemu/qemu-img.c:73: undefined reference to `g_sequence_lookup'
> > collect2: ld returned 1 exit status
> > make: *** [qemu-img] Error 1
> []
> > It appears that this code is dependent on glib.h function that is newer than one of my build systems
> > (RHEL 6 update 5, gcc version 4.4.7 20120313 (Red Hat 4.4.7-4))
> >
> > Is this a known limitation? i.e. is QEMU 2.1 going to prereq a newer version of glib2?
>
> If we're going to require more recent glib (g_sequence_lookup() first appeared in 2.26),
> let's require at least 2.31 with the new threading primitives as well.
It seems that would leave qemu unbuildable on the various "Enterprise"
distros. I have glib 2.22.5 on a SLES11SP3, and from this it seems
RHEL6.5 has an older glib as well.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] Build Broken?
2014-05-13 15:34 ` Michael Tokarev
2014-05-13 15:53 ` Cornelia Huck
@ 2014-05-13 15:55 ` Peter Maydell
2014-05-13 15:58 ` Tom Musta
2014-05-13 16:14 ` Paolo Bonzini
1 sibling, 2 replies; 6+ messages in thread
From: Peter Maydell @ 2014-05-13 15:55 UTC (permalink / raw)
To: Michael Tokarev; +Cc: Tom Musta, QEMU Developers
On 13 May 2014 16:34, Michael Tokarev <mjt@tls.msk.ru> wrote:
> 13.05.2014 18:17, Tom Musta wrote:
>> The current origin/master is not building for me:
>>
>> LINK qemu-img
>> qemu-img.o: In function `add_format_to_seq':
>> /bghome/tmusta/powerisa/qemu/qemu/qemu-img.c:73: undefined reference to `g_sequence_lookup'
>> collect2: ld returned 1 exit status
>> make: *** [qemu-img] Error 1
> []
>> It appears that this code is dependent on glib.h function that is newer than one of my build systems
>> (RHEL 6 update 5, gcc version 4.4.7 20120313 (Red Hat 4.4.7-4))
>>
>> Is this a known limitation? i.e. is QEMU 2.1 going to prereq a newer version of glib2?
>
> If we're going to require more recent glib (g_sequence_lookup() first appeared in 2.26),
> let's require at least 2.31 with the new threading primitives as well.
This is the wrong end to approach this question from, I think.
We should start with "which RedHat/Fedora/Debian/SuSE/etc
distro versions do we need to support?" and then can derive
the minimum glib version from that.
In particular, if RHEL6 doesn't have a glib with
g_sequence_lookup I think it's a fairly straightforward
decision to say we can't use it.
thanks
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] Build Broken?
2014-05-13 15:55 ` Peter Maydell
@ 2014-05-13 15:58 ` Tom Musta
2014-05-13 16:14 ` Paolo Bonzini
1 sibling, 0 replies; 6+ messages in thread
From: Tom Musta @ 2014-05-13 15:58 UTC (permalink / raw)
To: Peter Maydell, Michael Tokarev; +Cc: QEMU Developers
On 5/13/2014 10:55 AM, Peter Maydell wrote:
> On 13 May 2014 16:34, Michael Tokarev <mjt@tls.msk.ru> wrote:
>> 13.05.2014 18:17, Tom Musta wrote:
>>> The current origin/master is not building for me:
>>>
>>> LINK qemu-img
>>> qemu-img.o: In function `add_format_to_seq':
>>> /bghome/tmusta/powerisa/qemu/qemu/qemu-img.c:73: undefined reference to `g_sequence_lookup'
>>> collect2: ld returned 1 exit status
>>> make: *** [qemu-img] Error 1
>> []
>>> It appears that this code is dependent on glib.h function that is newer than one of my build systems
>>> (RHEL 6 update 5, gcc version 4.4.7 20120313 (Red Hat 4.4.7-4))
>>>
>>> Is this a known limitation? i.e. is QEMU 2.1 going to prereq a newer version of glib2?
>>
>> If we're going to require more recent glib (g_sequence_lookup() first appeared in 2.26),
>> let's require at least 2.31 with the new threading primitives as well.
>
> This is the wrong end to approach this question from, I think.
> We should start with "which RedHat/Fedora/Debian/SuSE/etc
> distro versions do we need to support?" and then can derive
> the minimum glib version from that.
>
> In particular, if RHEL6 doesn't have a glib with
> g_sequence_lookup I think it's a fairly straightforward
> decision to say we can't use it.
>
> thanks
> -- PMM
>
RHEL 6 is glib 2.26, I believe:
> rpm -q -f /usr/include/glib-2.0/glib.h
glib2-devel-2.26.1-3.el6.ppc64
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] Build Broken?
2014-05-13 15:55 ` Peter Maydell
2014-05-13 15:58 ` Tom Musta
@ 2014-05-13 16:14 ` Paolo Bonzini
1 sibling, 0 replies; 6+ messages in thread
From: Paolo Bonzini @ 2014-05-13 16:14 UTC (permalink / raw)
To: Peter Maydell, Michael Tokarev; +Cc: Tom Musta, QEMU Developers
Il 13/05/2014 17:55, Peter Maydell ha scritto:
> On 13 May 2014 16:34, Michael Tokarev <mjt@tls.msk.ru> wrote:
>> 13.05.2014 18:17, Tom Musta wrote:
>>> The current origin/master is not building for me:
>>>
>>> LINK qemu-img
>>> qemu-img.o: In function `add_format_to_seq':
>>> /bghome/tmusta/powerisa/qemu/qemu/qemu-img.c:73: undefined reference to `g_sequence_lookup'
>>> collect2: ld returned 1 exit status
>>> make: *** [qemu-img] Error 1
>> []
>>> It appears that this code is dependent on glib.h function that is newer than one of my build systems
>>> (RHEL 6 update 5, gcc version 4.4.7 20120313 (Red Hat 4.4.7-4))
>>>
>>> Is this a known limitation? i.e. is QEMU 2.1 going to prereq a newer version of glib2?
>>
>> If we're going to require more recent glib (g_sequence_lookup() first appeared in 2.26),
>> let's require at least 2.31 with the new threading primitives as well.
>
> This is the wrong end to approach this question from, I think.
> We should start with "which RedHat/Fedora/Debian/SuSE/etc
> distro versions do we need to support?" and then can derive
> the minimum glib version from that.
>
> In particular, if RHEL6 doesn't have a glib with
> g_sequence_lookup I think it's a fairly straightforward
> decision to say we can't use it.
I think we should stick for RHEL5's 2.12 for a few months still, at
least until RHEL7.0 or 7.1 comes out. Looks like SLES's 2.22 will be
the next lowest target.
Paolo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-05-13 16:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-13 14:17 [Qemu-devel] Build Broken? Tom Musta
2014-05-13 15:34 ` Michael Tokarev
2014-05-13 15:53 ` Cornelia Huck
2014-05-13 15:55 ` Peter Maydell
2014-05-13 15:58 ` Tom Musta
2014-05-13 16:14 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).