From: Eric Blake <eblake@redhat.com>
To: "Marc Marí" <marc.mari.barcelo@gmail.com>, qemu-devel@nongnu.org
Cc: "Stefan Hajnoczi" <stefanha@gmail.com>,
"Peter Crosthwaite" <peter.crosthwaite@xilinx.com>,
"Andreas Färber" <afaerber@suse.de>,
Overall <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] [PATCH v2 02/16] s390: Convert conditional compilation of debug printfs to regular ifs
Date: Tue, 13 May 2014 08:45:06 -0600 [thread overview]
Message-ID: <53722FF2.8060808@redhat.com> (raw)
In-Reply-To: <1399964572-5376-3-git-send-email-marc.mari.barcelo@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
On 05/13/2014 01:02 AM, Marc Marí wrote:
> Modify debug macros to have the same format through the codebase and use regular
> ifs instead of ifdef.
>
> As the debug printf is always put in code, some casting had to be added to avoid
> warnings treated as errors at compile time.
Same comments as in 1/16: make the commit message accurate, wrap long
lines, and see if you can avoid using gcc extensions.
>
> Signed-off-by: Marc Marí <marc.mari.barcelo@gmail.com>
> ---
> hw/s390x/s390-virtio-bus.c | 8 ++++----
> hw/s390x/s390-virtio.c | 8 ++++----
> target-s390x/helper.c | 22 ++++++++++++++--------
> target-s390x/kvm.c | 8 ++++----
> 4 files changed, 26 insertions(+), 20 deletions(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-05-13 14:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 7:02 [Qemu-devel] [PATCH v2 00/16] Convert conditional compilation of debug printfs Marc Marí
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 01/16] x86: Convert conditional compilation of debug printfs to regular ifs Marc Marí
2014-05-13 7:38 ` Andreas Färber
2014-05-13 15:15 ` Eric Blake
[not found] ` <53722E62.8000304@redhat.com>
2014-05-15 9:56 ` Marc Marí
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 02/16] s390: " Marc Marí
2014-05-13 9:04 ` Cornelia Huck
2014-05-13 14:45 ` Eric Blake [this message]
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 03/16] scsi: " Marc Marí
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 04/16] highbank: " Marc Marí
2014-05-13 10:06 ` Marc Marí
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 05/16] xilinx: " Marc Marí
2014-05-13 9:59 ` Marc Marí
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 06/16] spapr: " Marc Marí
2014-05-13 7:18 ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 07/16] stellaris: " Marc Marí
2014-05-13 15:05 ` Eric Blake
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 08/16] tpm: " Marc Marí
2014-05-13 9:39 ` Marc Marí
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 09/16] i82374: " Marc Marí
2014-05-13 9:20 ` Marc Marí
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 10/16] i8257: " Marc Marí
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 11/16] rc4030: " Marc Marí
2014-05-13 9:16 ` Marc Marí
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 12/16] sd: " Marc Marí
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 13/16] isa: " Marc Marí
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 14/16] lan9118: " Marc Marí
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 15/16] pci-host: " Marc Marí
2014-05-13 9:13 ` Marc Marí
2014-05-13 7:02 ` [Qemu-devel] [PATCH v2 16/16] common: " Marc Marí
2014-05-13 9:05 ` Cornelia Huck
2014-05-13 15:21 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53722FF2.8060808@redhat.com \
--to=eblake@redhat.com \
--cc=afaerber@suse.de \
--cc=kvm@vger.kernel.org \
--cc=marc.mari.barcelo@gmail.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).