From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56688) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkDxF-00015A-3f for qemu-devel@nongnu.org; Tue, 13 May 2014 10:45:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkDx9-0005ql-Bz for qemu-devel@nongnu.org; Tue, 13 May 2014 10:45:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53653) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkDx9-0005qb-3A for qemu-devel@nongnu.org; Tue, 13 May 2014 10:45:11 -0400 Message-ID: <53722FF2.8060808@redhat.com> Date: Tue, 13 May 2014 08:45:06 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399964572-5376-1-git-send-email-marc.mari.barcelo@gmail.com> <1399964572-5376-3-git-send-email-marc.mari.barcelo@gmail.com> In-Reply-To: <1399964572-5376-3-git-send-email-marc.mari.barcelo@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Hpi2HHFRaGle8OquNc0grjEFaCv7INmTk" Subject: Re: [Qemu-devel] [PATCH v2 02/16] s390: Convert conditional compilation of debug printfs to regular ifs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TWFyYyBNYXLDrQ==?= , qemu-devel@nongnu.org Cc: Stefan Hajnoczi , Peter Crosthwaite , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Overall This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Hpi2HHFRaGle8OquNc0grjEFaCv7INmTk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/13/2014 01:02 AM, Marc Mar=C3=AD wrote: > Modify debug macros to have the same format through the codebase and us= e regular > ifs instead of ifdef. >=20 > As the debug printf is always put in code, some casting had to be added= to avoid > warnings treated as errors at compile time. Same comments as in 1/16: make the commit message accurate, wrap long lines, and see if you can avoid using gcc extensions. >=20 > Signed-off-by: Marc Mar=C3=AD > --- > hw/s390x/s390-virtio-bus.c | 8 ++++---- > hw/s390x/s390-virtio.c | 8 ++++---- > target-s390x/helper.c | 22 ++++++++++++++-------- > target-s390x/kvm.c | 8 ++++---- > 4 files changed, 26 insertions(+), 20 deletions(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Hpi2HHFRaGle8OquNc0grjEFaCv7INmTk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTci/yAAoJEKeha0olJ0Nq06IIAI4bDxQa5aYj8szTXcjMGpTL /+Tqm3x8jhRfwyhj3ceVomdlcVIcllBAd86mo/v+v8R0nTIQ0aYKv51xX6FeEgZM 4CNlpGb942tadfEo6WEYN9+7fIvfesJ+S2GLHcsYLwxy5xqZ6B71gLfBqtdXQlFe tGu5iRLD7rlKZ/y5rQfdiCorQVBuJp7xOnKn2JkWhA0/iL8aTfBuT2jomKt1mfnA ekC7i8iYXwj2k9dsPWQWlKI+fPhiHqGcXhqStcrR5v70ZGHLnzFqeqZXPmzxy4xU 9h4LIhX77FHJDk1Wbkc3UGndLgD/vfOXYP0siSOg2GIryvlNKwiItHZch0Jv1BQ= =jdta -----END PGP SIGNATURE----- --Hpi2HHFRaGle8OquNc0grjEFaCv7INmTk--