From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkF63-0007yT-DZ for qemu-devel@nongnu.org; Tue, 13 May 2014 11:58:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkF5x-0006Ys-I0 for qemu-devel@nongnu.org; Tue, 13 May 2014 11:58:27 -0400 Received: from mail-yh0-x231.google.com ([2607:f8b0:4002:c01::231]:59167) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkF5x-0006YB-D6 for qemu-devel@nongnu.org; Tue, 13 May 2014 11:58:21 -0400 Received: by mail-yh0-f49.google.com with SMTP id c41so486963yho.22 for ; Tue, 13 May 2014 08:58:20 -0700 (PDT) Message-ID: <53724113.5000007@gmail.com> Date: Tue, 13 May 2014 10:58:11 -0500 From: Tom Musta MIME-Version: 1.0 References: <5372296E.60204@gmail.com> <53723B9D.1050303@msgid.tls.msk.ru> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Build Broken? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Michael Tokarev Cc: QEMU Developers On 5/13/2014 10:55 AM, Peter Maydell wrote: > On 13 May 2014 16:34, Michael Tokarev wrote: >> 13.05.2014 18:17, Tom Musta wrote: >>> The current origin/master is not building for me: >>> >>> LINK qemu-img >>> qemu-img.o: In function `add_format_to_seq': >>> /bghome/tmusta/powerisa/qemu/qemu/qemu-img.c:73: undefined reference to `g_sequence_lookup' >>> collect2: ld returned 1 exit status >>> make: *** [qemu-img] Error 1 >> [] >>> It appears that this code is dependent on glib.h function that is newer than one of my build systems >>> (RHEL 6 update 5, gcc version 4.4.7 20120313 (Red Hat 4.4.7-4)) >>> >>> Is this a known limitation? i.e. is QEMU 2.1 going to prereq a newer version of glib2? >> >> If we're going to require more recent glib (g_sequence_lookup() first appeared in 2.26), >> let's require at least 2.31 with the new threading primitives as well. > > This is the wrong end to approach this question from, I think. > We should start with "which RedHat/Fedora/Debian/SuSE/etc > distro versions do we need to support?" and then can derive > the minimum glib version from that. > > In particular, if RHEL6 doesn't have a glib with > g_sequence_lookup I think it's a fairly straightforward > decision to say we can't use it. > > thanks > -- PMM > RHEL 6 is glib 2.26, I believe: > rpm -q -f /usr/include/glib-2.0/glib.h glib2-devel-2.26.1-3.el6.ppc64