From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55290)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WkFQI-0001SU-Pn
	for qemu-devel@nongnu.org; Tue, 13 May 2014 12:19:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WkFQC-0005p4-RU
	for qemu-devel@nongnu.org; Tue, 13 May 2014 12:19:22 -0400
Received: from mail-qg0-x22e.google.com ([2607:f8b0:400d:c04::22e]:42334)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WkFQC-0005p0-Mm
	for qemu-devel@nongnu.org; Tue, 13 May 2014 12:19:16 -0400
Received: by mail-qg0-f46.google.com with SMTP id q108so670489qgd.5
	for <qemu-devel@nongnu.org>; Tue, 13 May 2014 09:19:16 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <537245FE.5060804@twiddle.net>
Date: Tue, 13 May 2014 09:19:10 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1399997154-19791-1-git-send-email-rth@twiddle.net>
	<CAFEAcA_QbOv_yR4VScTNLv1a-W8GVsRfRhuDF2L6PF9Rk+CvFw@mail.gmail.com>
In-Reply-To: <CAFEAcA_QbOv_yR4VScTNLv1a-W8GVsRfRhuDF2L6PF9Rk+CvFw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] exec-all.h: Don't use stl_p for patching
 x86 jumps
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 05/13/2014 09:10 AM, Peter Maydell wrote:
> On 13 May 2014 17:05, Richard Henderson <rth@twiddle.net> wrote:
>> Partial revert of 86360ad71df0070283469b8ae59f33cdd013501d,
>> because get the "wrong" version of stl_p, the one that does
>> byte swapping appropriate for the target.
> 
> Whoops. We could alternatively commit the patch renaming
> the bswap.h functions to use _he_ infixes and then use
> stl_he_p() here, yes?

Yes.

> Probably best to commit this as an immediate fix though.

That's what I was thinking.


r~