From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkFzo-0001gt-21 for qemu-devel@nongnu.org; Tue, 13 May 2014 12:56:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkFzh-0001jj-SE for qemu-devel@nongnu.org; Tue, 13 May 2014 12:56:04 -0400 Received: from mail-ee0-x236.google.com ([2a00:1450:4013:c00::236]:63578) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkFzh-0001jd-Kf for qemu-devel@nongnu.org; Tue, 13 May 2014 12:55:57 -0400 Received: by mail-ee0-f54.google.com with SMTP id b57so602901eek.41 for ; Tue, 13 May 2014 09:55:56 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <53724E99.9050008@redhat.com> Date: Tue, 13 May 2014 18:55:53 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1399997154-19791-1-git-send-email-rth@twiddle.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] exec-all.h: Don't use stl_p for patching x86 jumps List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Richard Henderson , qemu-devel Il 13/05/2014 18:10, Peter Maydell ha scritto: > On 13 May 2014 17:05, Richard Henderson wrote: >> Partial revert of 86360ad71df0070283469b8ae59f33cdd013501d, >> because get the "wrong" version of stl_p, the one that does >> byte swapping appropriate for the target. > > Whoops. We could alternatively commit the patch renaming > the bswap.h functions to use _he_ infixes and then use > stl_he_p() here, yes? Or use stl_le_p (a bit more readable that _he_). Paolo