From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkG7f-0007AF-Tl for qemu-devel@nongnu.org; Tue, 13 May 2014 13:04:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkG7a-0004Ct-T5 for qemu-devel@nongnu.org; Tue, 13 May 2014 13:04:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkG7a-0004Ch-Kd for qemu-devel@nongnu.org; Tue, 13 May 2014 13:04:06 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4DH46Rs016212 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 13 May 2014 13:04:06 -0400 Message-ID: <53725085.7080305@redhat.com> Date: Tue, 13 May 2014 11:04:05 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399996972-23429-1-git-send-email-armbru@redhat.com> <1399996972-23429-2-git-send-email-armbru@redhat.com> In-Reply-To: <1399996972-23429-2-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GNi268HDpmglsBnn6vhfNGWI3lQxwqdfG" Subject: Re: [Qemu-devel] [PATCH 01/18] blockdev: Don't use qerror_report_err() in drive_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GNi268HDpmglsBnn6vhfNGWI3lQxwqdfG Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/13/2014 10:02 AM, Markus Armbruster wrote: > qerror_report_err() is a transitional interface to help with > converting existing HMP commands to QMP. It should not be used > elsewhere. >=20 > drive_init() is not meant to be used by QMP commands. It uses both > qerror_report_err() and error_report(). Convert the former to the > latter. >=20 > Signed-off-by: Markus Armbruster > --- > blockdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --GNi268HDpmglsBnn6vhfNGWI3lQxwqdfG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTclCFAAoJEKeha0olJ0NqNmUIAJT9SrwVmdTCqEQrdaZ31nCW SToXJLjwMZXhdg3nn1v8shMjSgCAV4V70ROFOwf7KGnEDOISjhEprvdb6GDelPQe 9+wF3G5rWM6aFCHS9eK4XwrqXy5e2118GaF6nbZQdRxa5XO3LKkEmsTWqi3ptJfU IokIZc5Fpq99Y5LeS/xJxoWGidC8QbZQOmq23btJ5jX9b9XC22s0r2m4K2N9DqKD rwBaAJw75n5xMWmIg2xT9Cxh9SB1l5Yn6aA60NjssS6eHCLaN8htWojWkYjanPWq VJB74oHk3WNwz1IjmsyA376LkPSLn+WPG/mexk/gl/icAwti0kUoYPrytoFwM1E= =GKRD -----END PGP SIGNATURE----- --GNi268HDpmglsBnn6vhfNGWI3lQxwqdfG--