Re: [Qemu-devel] [PATCH 1/4] curl: Fix parsing of readahead option from filename

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 945 bytes --]

On 05/08/2014 02:42 AM, Matthew Booth wrote:
> curl_parse_filename wasn't removing the option string from the url,
> resulting in a 404.
> 
> This change is a rewrite of the previous parsing behaviour, and
> also changes the option syntax. The new syntax is:
> 
>   http://example.com/path?query[sslverify=off:readahead=64k]

Again, I'm not sure I'm happy with this - we shouldn't be inventing our
own syntax when URI is already a well-defined syntax.

> 
> The new syntax is well defined as long as square brackets in the URI
> are escaped.
> 
> This change is also preparation for the addition of more options.
> 
> Signed-off-by: Matthew Booth <mbooth@redhat.com>
> ---
>  block/curl.c | 101 +++++++++++++++++++++++++++++++++++++++--------------------
>  1 file changed, 67 insertions(+), 34 deletions(-)
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]