From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkGVw-0007lQ-VL for qemu-devel@nongnu.org; Tue, 13 May 2014 13:29:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkGVs-00043v-1e for qemu-devel@nongnu.org; Tue, 13 May 2014 13:29:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkGVr-00043l-QL for qemu-devel@nongnu.org; Tue, 13 May 2014 13:29:12 -0400 Message-ID: <53725664.7050904@redhat.com> Date: Tue, 13 May 2014 11:29:08 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399538540-5076-1-git-send-email-mbooth@redhat.com> <1399538540-5076-2-git-send-email-mbooth@redhat.com> In-Reply-To: <1399538540-5076-2-git-send-email-mbooth@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7H54n6rKRleNlpBkPFkiVuR7nmrlUl1Dv" Subject: Re: [Qemu-devel] [PATCH 1/4] curl: Fix parsing of readahead option from filename List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Matthew Booth , qemu-devel@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7H54n6rKRleNlpBkPFkiVuR7nmrlUl1Dv Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/08/2014 02:42 AM, Matthew Booth wrote: > curl_parse_filename wasn't removing the option string from the url, > resulting in a 404. >=20 > This change is a rewrite of the previous parsing behaviour, and > also changes the option syntax. The new syntax is: >=20 > http://example.com/path?query[sslverify=3Doff:readahead=3D64k] Again, I'm not sure I'm happy with this - we shouldn't be inventing our own syntax when URI is already a well-defined syntax. >=20 > The new syntax is well defined as long as square brackets in the URI > are escaped. >=20 > This change is also preparation for the addition of more options. >=20 > Signed-off-by: Matthew Booth > --- > block/curl.c | 101 +++++++++++++++++++++++++++++++++++++++------------= -------- > 1 file changed, 67 insertions(+), 34 deletions(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --7H54n6rKRleNlpBkPFkiVuR7nmrlUl1Dv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTclZkAAoJEKeha0olJ0NqkJ0H/i8mrAqeVHkQ8YAaeB5gwjjY dmRbE9m5qC6kvviPxeK7h8HwEpOeBKnAKDkMULVx6ASIez4LtVuGoMdu2Cj3G9SF Fhvu//ROj1/mHu6E+zizhbT7foH1LDoja7+vLvvtqomGcf6NWEoFIGSlqmGBSwKo biS+xXiXcs56Lob2FiYl0qjqSn+kpq0cA4uTSOiXtxmQrOtr7YqX8XKY3Sjcz3Fm Eqz//7AotlQogHxz5DyYq1JXOPBC97IC+fjfgII2RwIDdCicVBEknQJrRaHatTR3 K9tSWOjG54/F3BBXBhkmQ6iCJuDsPQXsXoZeh3UnYvQ9BKccN3Rlx8DKcOQK+eA= =FnpQ -----END PGP SIGNATURE----- --7H54n6rKRleNlpBkPFkiVuR7nmrlUl1Dv--