From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkGfl-0000FQ-Ns for qemu-devel@nongnu.org; Tue, 13 May 2014 13:39:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkGfb-0007V4-IN for qemu-devel@nongnu.org; Tue, 13 May 2014 13:39:25 -0400 Message-ID: <537258BC.6040505@suse.de> Date: Tue, 13 May 2014 19:39:08 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1399473780-20374-1-git-send-email-marcel.a@redhat.com> <1399473780-20374-4-git-send-email-marcel.a@redhat.com> In-Reply-To: <1399473780-20374-4-git-send-email-marcel.a@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/4] vl.c: do not set 'type' property in obj_set_property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , qemu-devel@nongnu.org, Paolo Bonzini Cc: mst@redhat.com, aik@ozlabs.ru, agraf@suse.de, blauwirbel@gmail.com, jcmvbkbc@gmail.com, edgar.iglesias@gmail.com, gxt@mprc.pku.edu.cn, proljc@gmail.com, armbru@redhat.com, scottwood@freescale.com, borntraeger@de.ibm.com, hpoussin@reactos.org, aliguori@amazon.com, lersek@redhat.com, mdroth@linux.vnet.ibm.com, chouteau@adacore.com, jan.kiszka@web.de, stefanha@redhat.com, cornelia.huck@de.ibm.com, lcapitulino@redhat.com, peter.crosthwaite@xilinx.com, mark.langsdorf@calxeda.com, michael@walle.cc, qemu-ppc@nongnu.org, peter.chubb@nicta.com.au, aurelien@aurel32.net Am 07.05.2014 16:42, schrieb Marcel Apfelbaum: > Filter out also 'type' property when setting > object's properties >=20 > Reviewed-by: Paolo Bonzini > Signed-off-by: Marcel Apfelbaum > --- > vl.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/vl.c b/vl.c > index 58673bd..6ec6c1a 100644 > --- a/vl.c > +++ b/vl.c > @@ -2889,7 +2889,8 @@ static int object_set_property(const char *name, = const char *value, void *opaque > StringInputVisitor *siv; > Error *local_err =3D NULL; > =20 > - if (strcmp(name, "qom-type") =3D=3D 0 || strcmp(name, "id") =3D=3D= 0) { > + if (strcmp(name, "qom-type") =3D=3D 0 || strcmp(name, "id") =3D=3D= 0 || > + strcmp(name, "type") =3D=3D 0) { > return 0; > } > =20 Seems sensible, although qom-type and type looks kind of odd at first. Given the Rb on this v1 patch, is this applied in any tree already? Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg