From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkI4Q-0005Xa-9i for qemu-devel@nongnu.org; Tue, 13 May 2014 15:09:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkI4L-00052g-QP for qemu-devel@nongnu.org; Tue, 13 May 2014 15:08:58 -0400 Message-ID: <53726D96.8030404@redhat.com> Date: Tue, 13 May 2014 13:08:06 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399473780-20374-1-git-send-email-marcel.a@redhat.com> <1399473780-20374-3-git-send-email-marcel.a@redhat.com> <53725800.3030404@suse.de> In-Reply-To: <53725800.3030404@suse.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0tQem5QMS2EBQUVaN3l1GSlqRsJ9FugEq" Subject: Re: [Qemu-devel] [PATCH 2/4] qapi: output visitor crashes qemu if it encounters a NULL value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Marcel Apfelbaum , qemu-devel@nongnu.org Cc: mst@redhat.com, aik@ozlabs.ru, lcapitulino@redhat.com, blauwirbel@gmail.com, jcmvbkbc@gmail.com, edgar.iglesias@gmail.com, gxt@mprc.pku.edu.cn, peter.chubb@nicta.com.au, proljc@gmail.com, agraf@suse.de, scottwood@freescale.com, borntraeger@de.ibm.com, hpoussin@reactos.org, aliguori@amazon.com, lersek@redhat.com, mdroth@linux.vnet.ibm.com, chouteau@adacore.com, jan.kiszka@web.de, stefanha@redhat.com, cornelia.huck@de.ibm.com, peter.crosthwaite@xilinx.com, mark.langsdorf@calxeda.com, armbru@redhat.com, michael@walle.cc, qemu-ppc@nongnu.org, pbonzini@redhat.com, aurelien@aurel32.net This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0tQem5QMS2EBQUVaN3l1GSlqRsJ9FugEq Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/13/2014 11:36 AM, Andreas F=C3=A4rber wrote: > Am 07.05.2014 16:42, schrieb Marcel Apfelbaum: >> A NULL value is not added to visitor's stack, but there >> is no check for that when the visitor tries to return >> that value, leading to Qemu crash. >> >> Reviewed-by: Eric Blake >> Signed-off-by: Marcel Apfelbaum >=20 > Where does the Rb come from on this v1? Is it in any tree already? >=20 The (weak) R-b was here: https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg02861.html --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --0tQem5QMS2EBQUVaN3l1GSlqRsJ9FugEq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTcm2WAAoJEKeha0olJ0NqvyUH/1eKoyh5Nu6fg+aBIDO/0Flr 2gcU274RBl0U4Bkpk0zERRQzsjE8tDh9Vcpa7gS90LEj7pLX6Mz1K77EGSs4qQJr F5jmzR6/FY6hEJ1ZCUodOa10UwW+ZTt27JwAu+XBHD/Tjdr9JlxoeEKEJqprjBZ2 OWf9kV9P0skOR/QCBpk3xzzxwN30Jk0nQdDzyS672rQWc6r/UKKBKbyQKxOsuadG CWGBncTdhrnocHcJPLqxiw1lgpVwyMqkIcnPFJ3KujkkOzzneLMNXhMhjmZCLCtj J7Nu9ZVJcNh7t0dtET4rZf/MAmRQuik3v12oVxCry6fRII4NU6UcqmNZtCR1UiI= =OrLe -----END PGP SIGNATURE----- --0tQem5QMS2EBQUVaN3l1GSlqRsJ9FugEq--