From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkIVy-0001cp-NA for qemu-devel@nongnu.org; Tue, 13 May 2014 15:37:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkIVu-0006hk-Ai for qemu-devel@nongnu.org; Tue, 13 May 2014 15:37:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44388) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkIVt-0006fh-U3 for qemu-devel@nongnu.org; Tue, 13 May 2014 15:37:22 -0400 Message-ID: <53727468.3030905@redhat.com> Date: Tue, 13 May 2014 13:37:12 -0600 From: Eric Blake MIME-Version: 1.0 References: <1400006069-11143-1-git-send-email-ncmike@ncultra.org> In-Reply-To: <1400006069-11143-1-git-send-email-ncmike@ncultra.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8RJ8B1e1I8lHorhnEVXmQhlUoax6t3S79" Subject: Re: [Qemu-devel] [PATCH] Remove g_sequence_lookup from qemu-img help function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mike Day , qemu-devel@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org, cornelia.huck@de.ibm.com, Markus Armbruster , stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8RJ8B1e1I8lHorhnEVXmQhlUoax6t3S79 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/13/2014 12:34 PM, Mike Day wrote: > g_sequence_lookup is not supported by glib < 2.28. The usage > of g_sequence_lookup is not essential in this context (its a s/its/it's/ > safeguard against duplicate values in the help message). > Removing the call enables the build on all platforms and > does not change the operation of the help function. >=20 > Signed-off-by: Mike Day > --- > qemu-img.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/qemu-img.c b/qemu-img.c > index 04ce02a..bf5e74c 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -70,11 +70,8 @@ static void add_format_to_seq(void *opaque, const ch= ar *fmt_name) > { > GSequence *seq =3D opaque; > =20 > - if (!g_sequence_lookup(seq, (gpointer)fmt_name, > - compare_data, NULL)) { > g_sequence_insert_sorted(seq, (gpointer)fmt_name, Indentation is now off. Please unindent the body now that you are removing the surrounding if. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --8RJ8B1e1I8lHorhnEVXmQhlUoax6t3S79 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTcnRoAAoJEKeha0olJ0NqQxYH/1FcYKwA6ERBVouwytO8T91m zPsn74e2RTFq5N+y12U0ekqzipHGEkqcRluOwYOObnTSgbj3CiSF4tIFLalfscW8 y4EPI2goSRuz6HzZebeMxWH9OofqwGbuVpPkwFwhc8WUpvnvo2SIUFRQWzuaqTmc 9TF6bhb19CaTeY66tO6UL5L+oe6E+2aM+rxkE/ajtE5lhr3/4a6UrMHSn6SRHedi R5d/uBMnZxlxseuY+2gbXYSHikV/ZXC6Zl4M4xwcWSJ6UfxT0qzraRmfiFY1gzo7 c6Wkcii1zY9cfFrktcsC0CGL4dz5vXFQ5BsyQx5+HKpHdBk4x48bLrDDq9lZIGA= =/VwL -----END PGP SIGNATURE----- --8RJ8B1e1I8lHorhnEVXmQhlUoax6t3S79--