From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkIXP-0002ph-Um for qemu-devel@nongnu.org; Tue, 13 May 2014 15:39:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkIXL-0006zZ-0m for qemu-devel@nongnu.org; Tue, 13 May 2014 15:38:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39568) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkIXK-0006zV-P4 for qemu-devel@nongnu.org; Tue, 13 May 2014 15:38:50 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4DJcnRK026291 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 13 May 2014 15:38:50 -0400 Message-ID: <537274C9.6030604@redhat.com> Date: Tue, 13 May 2014 13:38:49 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399996972-23429-1-git-send-email-armbru@redhat.com> <1399996972-23429-3-git-send-email-armbru@redhat.com> In-Reply-To: <1399996972-23429-3-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8QkE1iQP4Hh9m97WPkl0fwEnrTasnW594" Subject: Re: [Qemu-devel] [PATCH 02/18] blockdev: Don't use qerror_report() in do_drive_del() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8QkE1iQP4Hh9m97WPkl0fwEnrTasnW594 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/13/2014 10:02 AM, Markus Armbruster wrote: > qerror_report() is a transitional interface to help with converting > existing HMP commands to QMP. It should not be used elsewhere. >=20 > do_drive_del() is an HMP command that won't be converted to QMP (we'll > create a new QMP command instead). It uses both qerror_report() and > error_report(). Convert the former to the latter. >=20 > Signed-off-by: Markus Armbruster > --- > blockdev.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --8QkE1iQP4Hh9m97WPkl0fwEnrTasnW594 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTcnTJAAoJEKeha0olJ0NqYUkH/idh9LaUFcYq9nt9PwJWbSn5 RCqdKjTkHAan9rns7m4ezY55IeXTN5ZXb+fazO2ktMbf8hSSeGgjI1/k/RbP04Y3 IQ+DaqFNV9W/cO/I/OvY6mr6s8bunTk06L90t1o+mL5gX+vzP2uhw9Rf3LlREpsS +L0Sf0VGuAFnuhKvCwosA0KCXhmdNE6vlBwDrcYTPIYbpwazbHAQs0Zo8pdC0ZOu nRQurFcECqOvIUlRu5oSqqCzIdD6iN4zS4oHEsW6JGtRmUeXa6i47J5wYibVd8Uk 475oZxEhxegjh6+4HkDRW82F0//zQZVM5rye9h9HJNFRR1VI2LP7eML+DivtGvU= =4Mr5 -----END PGP SIGNATURE----- --8QkE1iQP4Hh9m97WPkl0fwEnrTasnW594--