From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkIk7-0003lu-Ci for qemu-devel@nongnu.org; Tue, 13 May 2014 15:52:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkIk2-0002vu-Vf for qemu-devel@nongnu.org; Tue, 13 May 2014 15:52:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43248) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkIk2-0002vq-O3 for qemu-devel@nongnu.org; Tue, 13 May 2014 15:51:58 -0400 Message-ID: <537277DC.9010307@redhat.com> Date: Tue, 13 May 2014 13:51:56 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399996972-23429-1-git-send-email-armbru@redhat.com> <1399996972-23429-5-git-send-email-armbru@redhat.com> In-Reply-To: <1399996972-23429-5-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Cwve4o82Qgqo6VBI3CDVIr0K8umlsKiO0" Subject: Re: [Qemu-devel] [PATCH 04/18] block/rbd: Propagate errors to open and create methods List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Josh Durgin , stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Cwve4o82Qgqo6VBI3CDVIr0K8umlsKiO0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/13/2014 10:02 AM, Markus Armbruster wrote: > Completes the conversion to Error started in commit 015a103^..d5124c0. >=20 > Cc: Josh Durgin > Signed-off-by: Markus Armbruster > --- > block/rbd.c | 66 +++++++++++++++++++++++++++++++----------------------= -------- > 1 file changed, 34 insertions(+), 32 deletions(-) >=20 > @@ -285,6 +289,7 @@ static int qemu_rbd_set_conf(rados_t cluster, const= char *conf) > static int qemu_rbd_create(const char *filename, QEMUOptionParameter *= options, > Error **errp) > { > + Error *local_err =3D NULL; > int64_t bytes =3D 0; > int64_t objsize; > int obj_order =3D 0; > @@ -301,7 +306,7 @@ static int qemu_rbd_create(const char *filename, QE= MUOptionParameter *options, > if (qemu_rbd_parsename(filename, pool, sizeof(pool), > snap_buf, sizeof(snap_buf), > name, sizeof(name), > - conf, sizeof(conf)) < 0) { > + conf, sizeof(conf), &local_err) < 0) { > return -EINVAL; Doesn't this leak local_err? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Cwve4o82Qgqo6VBI3CDVIr0K8umlsKiO0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTcnfcAAoJEKeha0olJ0Nqd3gH/1BHAwolF4j4pakIuO2JcIJ+ bi89xYO14d8mNPlVF3/Ep0OD7eZvgUyg8Kc57I86xVRBOUj/mV8nthUsB4B6rSYI 2N4YnDEvDTniKSZx1HIWrj2thsnLETsnWCqsdDaOqXr/+eUVuJUQYl7Y62tDInJv Y0JPjEqLpqOJUPL25sbTRT7UwKNl2vrKQ+bvXRKhP5BaX88vR12yAGm7v6KvHSgy TtXplnqCNi04W9mrTZu78v5qDRg0o+brxp0C8/nTaNvk3oZlYcCrKf+xgF3k4lZW /yOiXIG6PFdyCSbJs0sYL+7bnglXu0ExxOSSyq/UtU6K4IirSbSwR8fV7DuH9lo= =fnxy -----END PGP SIGNATURE----- --Cwve4o82Qgqo6VBI3CDVIr0K8umlsKiO0--