From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54524)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WkJ1U-0005b8-QU
	for qemu-devel@nongnu.org; Tue, 13 May 2014 16:10:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WkJ1L-0007pz-Qe
	for qemu-devel@nongnu.org; Tue, 13 May 2014 16:10:00 -0400
Received: from mail-ee0-x22b.google.com ([2a00:1450:4013:c00::22b]:51149)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WkJ1L-0007pn-JP
	for qemu-devel@nongnu.org; Tue, 13 May 2014 16:09:51 -0400
Received: by mail-ee0-f43.google.com with SMTP id d17so741429eek.16
	for <qemu-devel@nongnu.org>; Tue, 13 May 2014 13:09:50 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <53727C09.1010208@redhat.com>
Date: Tue, 13 May 2014 22:09:45 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1400005030-20729-1-git-send-email-somlo@cmu.edu>
	<1400005030-20729-2-git-send-email-somlo@cmu.edu>
In-Reply-To: <1400005030-20729-2-git-send-email-somlo@cmu.edu>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/2] SMBIOS: Fix endian-ness when
 populating fields wider than 8-bit
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Gabriel L. Somlo" <gsomlo@gmail.com>, qemu-devel@nongnu.org
Cc: lersek@redhat.com, kraxel@redhat.com

Il 13/05/2014 20:17, Gabriel L. Somlo ha scritto:
> -    t->processor_id[0] = smbios_cpuid_version;
> -    t->processor_id[1] = smbios_cpuid_features;
> +    t->processor_id[0] = smbios_cpuid_version; /* opaque, no cpu_to_le16 */
> +    t->processor_id[1] = smbios_cpuid_features; /* opaque, no cpu_to_le16 */

Actually I think these should be subject to cpu_to_le32.  They 
correspond to CPUID values, so they are little-endian 32-bit.

Paolo