From: Eric Blake <eblake@redhat.com>
To: Mike Day <ncmike@ncultra.org>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org,
cornelia.huck@de.ibm.com, armbru@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Remove g_sequence_lookup from qemu-img help function
Date: Tue, 13 May 2014 15:48:26 -0600 [thread overview]
Message-ID: <5372932A.40001@redhat.com> (raw)
In-Reply-To: <1400015466-16048-1-git-send-email-ncmike@ncultra.org>
[-- Attachment #1: Type: text/plain, Size: 789 bytes --]
On 05/13/2014 03:11 PM, Mike Day wrote:
Subject line could have used a [PATCHv2] designation to make it obvious
this is a fixed version. But that doesn't affect what goes into git.
> g_sequence_lookup is not supported by glib < 2.28. The usage
> of g_sequence_lookup is not essential in this context (it's a
> safeguard against duplicate values in the help message).
> Removing the call enables the build on all platforms and
> does not change the operation of the help function.
>
> Signed-off-by: Mike Day <ncmike@ncultra.org>
> ---
> qemu-img.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-05-13 21:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 21:11 [Qemu-devel] [PATCH] Remove g_sequence_lookup from qemu-img help function Mike Day
2014-05-13 21:48 ` Eric Blake [this message]
2014-05-14 7:44 ` Kevin Wolf
2014-05-14 8:23 ` Peter Maydell
2014-05-16 12:35 ` Alexander Graf
2014-05-14 6:31 ` Cornelia Huck
-- strict thread matches above, loose matches on Subject: below --
2014-05-13 18:34 Mike Day
2014-05-13 19:37 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5372932A.40001@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=kwolf@redhat.com \
--cc=ncmike@ncultra.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).