From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkKYv-0002ih-Iv for qemu-devel@nongnu.org; Tue, 13 May 2014 17:48:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkKYr-0006z9-64 for qemu-devel@nongnu.org; Tue, 13 May 2014 17:48:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62653) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkKYq-0006z1-T3 for qemu-devel@nongnu.org; Tue, 13 May 2014 17:48:33 -0400 Message-ID: <5372932A.40001@redhat.com> Date: Tue, 13 May 2014 15:48:26 -0600 From: Eric Blake MIME-Version: 1.0 References: <1400015466-16048-1-git-send-email-ncmike@ncultra.org> In-Reply-To: <1400015466-16048-1-git-send-email-ncmike@ncultra.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vFxBnojJcKtIVAb80pUgJwJnuhkReCV5w" Subject: Re: [Qemu-devel] [PATCH] Remove g_sequence_lookup from qemu-img help function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mike Day , qemu-devel@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org, cornelia.huck@de.ibm.com, armbru@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vFxBnojJcKtIVAb80pUgJwJnuhkReCV5w Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/13/2014 03:11 PM, Mike Day wrote: Subject line could have used a [PATCHv2] designation to make it obvious this is a fixed version. But that doesn't affect what goes into git. > g_sequence_lookup is not supported by glib < 2.28. The usage > of g_sequence_lookup is not essential in this context (it's a > safeguard against duplicate values in the help message). > Removing the call enables the build on all platforms and > does not change the operation of the help function. >=20 > Signed-off-by: Mike Day > --- > qemu-img.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --vFxBnojJcKtIVAb80pUgJwJnuhkReCV5w Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTcpMqAAoJEKeha0olJ0NqoUIH/1bQsLR8Enm19P9ZZvGYFDVv DjSzVk/7/2fMF2TgTMuovvESiYp6koWAjaTOEZH1adInEUm8gd/+t3Ao8EiuRCaW qNlsxgIQc3mEw2m1mPe3b7hifz8O6sjeScL+cIu9QdokXVWpc8jI+sc5BnEJzw46 NQF5b++D9cmnqjymn9UQl10ZZZbm8M20VRaIofj+a4AvyLuxMcJnLIpdv7u/GQaU CAhtf0Rbchaul++WXEz0bY34eZgOTmi9bQSTpMTylpck+cXF1Lnrhsli5ecVmcM8 EAilYV2oetQmW2+GURF7Byy6E83RYZueS9mDsb2w6lfs3h3aYrFKPCs+AjRkhgc= =ZPgk -----END PGP SIGNATURE----- --vFxBnojJcKtIVAb80pUgJwJnuhkReCV5w--