From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48015) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkcV1-0007Pb-BV for qemu-devel@nongnu.org; Wed, 14 May 2014 12:57:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkcUw-0006hJ-DZ for qemu-devel@nongnu.org; Wed, 14 May 2014 12:57:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4792) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkcUw-0006h7-7D for qemu-devel@nongnu.org; Wed, 14 May 2014 12:57:42 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4EGveVV001306 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 14 May 2014 12:57:40 -0400 Message-ID: <5373A083.3050409@redhat.com> Date: Wed, 14 May 2014 10:57:39 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399996972-23429-1-git-send-email-armbru@redhat.com> <1399996972-23429-11-git-send-email-armbru@redhat.com> In-Reply-To: <1399996972-23429-11-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rcNSfxQV4k8OicNeeP1bieAqpx3XDXMPN" Subject: Re: [Qemu-devel] [PATCH 10/18] block/vvfat: Propagate errors through enable_write_target() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rcNSfxQV4k8OicNeeP1bieAqpx3XDXMPN Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/13/2014 10:02 AM, Markus Armbruster wrote: > Continues the conversion of the open method to Error started in commit > 015a103. >=20 > Signed-off-by: Markus Armbruster > --- > block/vvfat.c | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) >=20 > s->qcow =3D NULL; > ret =3D bdrv_open(&s->qcow, s->qcow_filename, NULL, NULL, > BDRV_O_RDWR | BDRV_O_CACHE_WB | BDRV_O_NO_FLUSH, bdrv_qcow= , > - &local_err); > + errp); Pre-existing; indentation looks odd here if you want to touch it up at the same time. But that's not a show-stopper. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --rcNSfxQV4k8OicNeeP1bieAqpx3XDXMPN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTc6CDAAoJEKeha0olJ0NqjYYH/jiIlo1jj2jmAGNkoIH1pYqN XNyLjUyjT2VtMaO9K8czDY7r3iO3IuE7cdiHyrL7ai/2iKZcNYvbYYFONxQJ5ggi Qd3ybcOrNzRAIgUPL+MX5BnTjOimeRw2sCw/AsXN2ElLVz7ElqAUgDRbL8CeEILR /rONodXrNrpatHJZujBzUTndvv7YXZAtw7TViQvptycliiDX3YdQ48wBVAZqC3mA h3omssMFyzlNE8aLz+nQaOgAMeGbl3uOJbYuwI/RDrIWIxBp98wTsQnF2CihHV8f y/aedrQcQWpDDaThbT+hchIrBzP59/E4jpYYZHUexFHICz5RJT26EfRxtn2rlQY= =1BIa -----END PGP SIGNATURE----- --rcNSfxQV4k8OicNeeP1bieAqpx3XDXMPN--