qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Matthew Booth <mbooth@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org
Subject: Re: [Qemu-devel] Curl updates
Date: Wed, 14 May 2014 11:02:42 -0600	[thread overview]
Message-ID: <5373A1B2.9060602@redhat.com> (raw)
In-Reply-To: <53739475.5090908@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]

On 05/14/2014 10:06 AM, Matthew Booth wrote:

>>> The new syntax is:
>>>
>>> http://user:password@example.com/path?query[opt1=val:opt2=val]
>>>

> 
> A URI can, by definition, contain a query string, and we cannot assume
> that it won't. In fact, the use case I'm specifically interested in
> always includes a query string. If we try to overload the query
> string, we're adding heuristic fuzziness. My syntax makes the option
> string distinct from the URI, so no heuristics are required. It's also
> very clear to read IMHO.

But your proposed syntax is no longer a URI.  I'd much rather see:

'json:{"driver":"curl","filename":"http://user:password@example.com/path?query","opt1":"val","opt2":"val"}'

which then shares the same syntax as all other drivers for creating a
flat string that encodes multiple pieces of information, rather than
having to overload the filename to be a non-URI encoding locally useful
information.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2014-05-14 17:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-08  8:42 [Qemu-devel] Curl updates Matthew Booth
2014-05-08  8:42 ` [Qemu-devel] [PATCH 1/4] curl: Fix parsing of readahead option from filename Matthew Booth
2014-05-13 17:29   ` Eric Blake
2014-05-14 16:00     ` Matthew Booth
2014-05-14 16:55       ` Eric Blake
2014-05-08  8:42 ` [Qemu-devel] [PATCH 2/4] curl: Add sslverify option Matthew Booth
2014-05-08  8:42 ` [Qemu-devel] [PATCH 3/4] curl: Add usage documentation Matthew Booth
2014-05-08  8:42 ` [Qemu-devel] [PATCH 4/4] curl: Fix build when curl_multi_socket_action isn't available Matthew Booth
2014-05-13 19:47 ` [Qemu-devel] Curl updates Eric Blake
2014-05-14  7:48   ` Kevin Wolf
2014-05-14 12:59     ` Eric Blake
2014-05-14 16:08     ` Matthew Booth
2014-05-14 16:43       ` Kevin Wolf
2014-05-14 21:20         ` Matthew Booth
2014-05-14 21:36           ` Eric Blake
2014-05-14 16:59       ` Eric Blake
2014-05-14 16:06   ` Matthew Booth
2014-05-14 17:02     ` Eric Blake [this message]
2014-05-14 20:45       ` Matthew Booth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5373A1B2.9060602@redhat.com \
    --to=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mbooth@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).