From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkdFH-0005Di-UK for qemu-devel@nongnu.org; Wed, 14 May 2014 13:45:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkdFD-0006I1-AM for qemu-devel@nongnu.org; Wed, 14 May 2014 13:45:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20346) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkdFC-0006Hi-Vv for qemu-devel@nongnu.org; Wed, 14 May 2014 13:45:31 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4EHjTEN005318 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 14 May 2014 13:45:30 -0400 Message-ID: <5373ABB8.5020004@redhat.com> Date: Wed, 14 May 2014 11:45:28 -0600 From: Eric Blake MIME-Version: 1.0 References: <1399996972-23429-1-git-send-email-armbru@redhat.com> <1399996972-23429-12-git-send-email-armbru@redhat.com> In-Reply-To: <1399996972-23429-12-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SVGqTw7JCcUXBsa2t5M6CMikh7LL9Ng8u" Subject: Re: [Qemu-devel] [PATCH 11/18] block/vvfat: Propagate errors through init_directories() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SVGqTw7JCcUXBsa2t5M6CMikh7LL9Ng8u Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/13/2014 10:02 AM, Markus Armbruster wrote: > Completes the conversion of the open method to Error started in commit > 015a103. >=20 > Signed-off-by: Markus Armbruster > --- > block/vvfat.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) >=20 > @@ -892,8 +893,8 @@ static int init_directories(BDRVVVFATState* s, > if (mapping->mode & MODE_DIRECTORY) { > mapping->begin =3D cluster; > if(read_directory(s, i)) { > - fprintf(stderr, "Could not read directory %s\n", > - mapping->path); > + error_setg(errp, "Could not read directory %s", > + mapping->path); I see you fixed some TABs in the process; is it worth widening the fix to the rest of the 'if' statement? I don't care either way, as long as checkpatch.pl didn't call you out (the new code is correct, even though the existing code was not). Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --SVGqTw7JCcUXBsa2t5M6CMikh7LL9Ng8u Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTc6u4AAoJEKeha0olJ0NqFrsIAImjh4ZB8dRK06MugAwa8+uZ IlS8cuRNKJoDM/iIOQK5BmNhW5QCTADhWSBIgj3XisXX5SRCzVU1JyYbDxDf5hy+ RPwRAboFpAUYMmG17FvEp847EBR3de+heNR7KUdfPE5rj2SX4e8tMIgQlkAa5fqv OLE0Xf1+t1GcAaHd5wsIWpBJlBgu31jy5SGIVU+bzm7+9qrN5hT7b5BmzyTNJzRA 5dc7W48DWuBnKws3iBWZ9tpiVpa/bf/0X83muys6dyJ1rN1k8aE1u3u2O6Ss7CGI JKYHde+UEqMiBXlFN0PU4wKGmY6XmE/ny2zhrYhjek/p1nh5VvKLq5s9ySCFYFg= =CQ/K -----END PGP SIGNATURE----- --SVGqTw7JCcUXBsa2t5M6CMikh7LL9Ng8u--