From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wkg3s-0000j9-V6 for qemu-devel@nongnu.org; Wed, 14 May 2014 16:46:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wkg3o-0007rd-00 for qemu-devel@nongnu.org; Wed, 14 May 2014 16:46:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wkg3n-0007rZ-O3 for qemu-devel@nongnu.org; Wed, 14 May 2014 16:45:55 -0400 Message-ID: <5373D5FE.6020907@redhat.com> Date: Wed, 14 May 2014 16:45:50 -0400 From: Matthew Booth MIME-Version: 1.0 References: <1399538540-5076-1-git-send-email-mbooth@redhat.com> <537276C6.5010308@redhat.com> <53739475.5090908@redhat.com> <5373A1B2.9060602@redhat.com> In-Reply-To: <5373A1B2.9060602@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Curl updates List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 14/05/14 13:02, Eric Blake wrote: > On 05/14/2014 10:06 AM, Matthew Booth wrote: > >>>> The new syntax is: >>>> >>>> http://user:password@example.com/path?query[opt1=val:opt2=val] >>>> > >>>> >> >> A URI can, by definition, contain a query string, and we cannot >> assume that it won't. In fact, the use case I'm specifically >> interested in always includes a query string. If we try to >> overload the query string, we're adding heuristic fuzziness. My >> syntax makes the option string distinct from the URI, so no >> heuristics are required. It's also very clear to read IMHO. > > But your proposed syntax is no longer a URI. I'd much rather see: > > 'json:{"driver":"curl","filename":"http://user:password@example.com/path?query","opt1":"val","opt2":"val"}' > > which then shares the same syntax as all other drivers for > creating a flat string that encodes multiple pieces of information, > rather than having to overload the filename to be a non-URI > encoding locally useful information. > Agree: if it's possible to pass explicit parameters to a backing file then we should ditch the hokey parsing. I'll check out the new syntax, rip out the parser and update the docs. Matt - -- Matthew Booth Red Hat Engineering, Virtualisation Team Phone: +442070094448 (UK) GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlNz1f4ACgkQNEHqGdM8NJBQ8ACfeekpMvSJS0kh1sx+/gtT6lS6 nwgAn2yxW2ympFXfvTybxQhBfdL907Cc =HDQu -----END PGP SIGNATURE-----