From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47797)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Wkhxf-0006t9-1p
	for qemu-devel@nongnu.org; Wed, 14 May 2014 18:47:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Wkhxa-0004ct-7v
	for qemu-devel@nongnu.org; Wed, 14 May 2014 18:47:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41862)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Wkhxa-0004cl-05
	for qemu-devel@nongnu.org; Wed, 14 May 2014 18:47:38 -0400
Message-ID: <5373F283.7020704@redhat.com>
Date: Thu, 15 May 2014 00:47:31 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1400077612-28488-1-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1400077612-28488-1-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] configure: Ensure tests/qemu-iotests
 exists before writing common.env
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Markus Armbruster <armbru@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

On 14.05.2014 16:26, Peter Maydell wrote:
> Before we write common.env to the tests/qemu-iotests directory, ensure
> that it exists. This fixes out-of-tree builds from clean.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> If somebody would like to review this I'll apply it to master as
> a buildfix...
>
>   configure | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/configure b/configure
> index 6adfa72..c4e43ed 100755
> --- a/configure
> +++ b/configure
> @@ -4770,6 +4770,7 @@ fi
>   
>   iotests_common_env="tests/qemu-iotests/common.env"
>   
> +mkdir -p "$(dirname "$iotests_common_env")"
>   echo "# Automatically generated by configure - do not modify" > $iotests_common_env
>   echo >> $iotests_common_env
>   echo "PYTHON='$python'" >> $iotests_common_env

If we do this, we'd have a commen.env which we cannot use, as all the 
tests are still in the original source tree.

I'd rather use "$source_path/tests/qemu_iotests/common.env" instead, or, 
if that is unacceptable as it modifies the original source tree (which 
is probably not desired when doing an out-of-tree build), write 
common.env only if this is an in-tree build.

Max