From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60167) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkioM-0005aM-Eo for qemu-devel@nongnu.org; Wed, 14 May 2014 19:42:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkioG-0004jw-AZ for qemu-devel@nongnu.org; Wed, 14 May 2014 19:42:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38100) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkioG-0004jo-2N for qemu-devel@nongnu.org; Wed, 14 May 2014 19:42:04 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4ENg3W9009353 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 14 May 2014 19:42:03 -0400 Message-ID: <5373FF47.7020809@redhat.com> Date: Thu, 15 May 2014 01:41:59 +0200 From: Max Reitz MIME-Version: 1.0 References: <1399128428-25546-1-git-send-email-mreitz@redhat.com> <87y4y4pmja.fsf@blackfin.pond.sub.org> In-Reply-To: <87y4y4pmja.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] iotests: Use configured python List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi On 14.05.2014 14:33, Markus Armbruster wrote: > Max Reitz writes: > >> Currently, QEMU's iotests rely on /usr/bin/env to start the correct >> Python (that is, at least Python 2.4, but not 3). On systems where >> Python 3 is the default, the user has no clean way of making the iotests >> use the correct binary. >> >> This commit makes the iotests use the Python selected by configure. >> >> Signed-off-by: Max Reitz > I'm afraid this broke qemu-iotests in a separate build tree: > > ./check: line 38: ./common.env: No such file or directory As I already replied to Peter, I see two (or maybe three) ways to fix this: The first is, we use the correct path to common.env. This would however result in modification of the source tree although this is probably not what the user intends with an out-of-tree build. On the other hand, this would just work. The second is, we do not create common.env for out-of-tree builds and add a default common.env to the repository ("PYTHON = python" should probably suffice). This would not introduce any regressions, however, the iotests would remain problematic on systems with Python 3 being the default when using out-of-tree builds. As I guess that out-of-tree builds are actually recommended, this would mean that the better solution might be to revert my patch and instead change every "python" occurrence in the iotests' Shebangs to "python2", as kind of a third way to go. However, for this I'm not sure whether all systems which are supposed to be supported by qemu actually have a "python2" executable/symlink. I guess so, but then again... So, either we fix it but try to write to the source tree without the user intending to modify it; or we fix it for in-tree builds only; or we drop the magic and just use "python2" in the iotests' Shebangs. Max