From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkjnG-00054R-RN for qemu-devel@nongnu.org; Wed, 14 May 2014 20:45:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wkjn9-0001cg-My for qemu-devel@nongnu.org; Wed, 14 May 2014 20:45:06 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:55713) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wkjn9-0001cO-Da for qemu-devel@nongnu.org; Wed, 14 May 2014 20:44:59 -0400 Received: from /spool/local by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 14 May 2014 18:44:57 -0600 Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 9D9FE19D8039 for ; Wed, 14 May 2014 18:44:47 -0600 (MDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by b03cxnp07028.gho.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s4F0hdkZ5374454 for ; Thu, 15 May 2014 02:43:47 +0200 Received: from d03av03.boulder.ibm.com (localhost [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s4F0iKJk026916 for ; Wed, 14 May 2014 18:44:20 -0600 Message-ID: <53740DC0.4030905@linux.vnet.ibm.com> Date: Thu, 15 May 2014 08:43:44 +0800 From: "Michael R. Hines" MIME-Version: 1.0 References: <1396078745-5584-1-git-send-email-arei.gonglei@huawei.com> <533A0B67.6010308@linux.vnet.ibm.com> <33183CC9F5247A488A2544077AF19020815E739F@SZXEMA503-MBS.china.huawei.com> In-Reply-To: <33183CC9F5247A488A2544077AF19020815E739F@SZXEMA503-MBS.china.huawei.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] rdma: Fix block during rdma migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gonglei (Arei)" , "qemu-devel@nongnu.org" Cc: "Huangweidong (C)" , "quintela@redhat.com" , "dgilbert@redhat.com" , "owasserm@redhat.com" , "mrhines@us.ibm.com" , Moyuxiang , "pbonzini@redhat.com" On 05/09/2014 12:25 PM, Gonglei (Arei) wrote: > Hi, > >> -----Original Message----- >> From: Michael R. Hines [mailto:mrhines@linux.vnet.ibm.com] >> Sent: Tuesday, April 01, 2014 8:42 AM >> To: Gonglei (Arei); qemu-devel@nongnu.org >> Cc: Huangweidong (C); quintela@redhat.com; dgilbert@redhat.com; >> owasserm@redhat.com; mrhines@us.ibm.com; Moyuxiang; >> pbonzini@redhat.com >> Subject: Re: [Qemu-devel] [PATCH] rdma: Fix block during rdma migration >> >> On 03/29/2014 03:39 PM, arei.gonglei@huawei.com wrote: >>> From: Mo Yuxiang >>> >>> If the networking break or there's something wrong with rdma >>> device(ib0 with no IP) during rdma migration, the main_loop of >>> qemu will be blocked in rdma_destroy_id. I add rdma_ack_cm_event >>> to fix this bug. >>> >>> Signed-off-by: Mo Yuxiang >>> Signed-off-by: Gonglei >>> --- >>> migration-rdma.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/migration-rdma.c b/migration-rdma.c >>> index eeb4302..f60749b 100644 >>> --- a/migration-rdma.c >>> +++ b/migration-rdma.c >>> @@ -949,6 +949,7 @@ route: >>> ERROR(errp, "result not equal to event_addr_resolved %s", >>> rdma_event_str(cm_event->event)); >>> perror("rdma_resolve_addr"); >>> + rdma_ack_cm_event(cm_event); >>> ret = -EINVAL; >>> goto err_resolve_get_addr; >>> } >> Reviewed-by: Michael R. Hines >> >> Good catch. =) That's an obvious bug. It looks like I need >> to do a much better job of "kill -9" inside the regression >> testing scripts - probably i should try killing the migration >> prematurely at different periods just to be sure there are >> no more places where the connection state is not getting >> cleaned up...... >> >> - Michael >> > Michael, do you have a plan to pull this patch to master? Thanks. > > Best regards, > -Gonglei > Sorry for the late reply, but I'm not the maintainer for migration, that's Juan (I can only signoff on patches like everyone else =). I also have outstanding RDMA patches myself that have not yet been pulled. Would you mind pinging Juan for both of us? - Michael - Michael