* [Qemu-devel] [PATCH] rdma: Fix block during rdma migration
@ 2014-03-29 7:39 arei.gonglei
2014-04-01 0:42 ` Michael R. Hines
0 siblings, 1 reply; 9+ messages in thread
From: arei.gonglei @ 2014-03-29 7:39 UTC (permalink / raw)
To: qemu-devel
Cc: weidong.huang, quintela, dgilbert, owasserm, Gonglei, mrhines,
Mo Yuxiang, pbonzini
From: Mo Yuxiang <Moyuxiang@huawei.com>
If the networking break or there's something wrong with rdma
device(ib0 with no IP) during rdma migration, the main_loop of
qemu will be blocked in rdma_destroy_id. I add rdma_ack_cm_event
to fix this bug.
Signed-off-by: Mo Yuxiang <Moyuxiang@huawei.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
migration-rdma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration-rdma.c b/migration-rdma.c
index eeb4302..f60749b 100644
--- a/migration-rdma.c
+++ b/migration-rdma.c
@@ -949,6 +949,7 @@ route:
ERROR(errp, "result not equal to event_addr_resolved %s",
rdma_event_str(cm_event->event));
perror("rdma_resolve_addr");
+ rdma_ack_cm_event(cm_event);
ret = -EINVAL;
goto err_resolve_get_addr;
}
--
1.7.12.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [Qemu-devel] [PATCH] rdma: Fix block during rdma migration
2014-03-29 7:39 [Qemu-devel] [PATCH] rdma: Fix block during rdma migration arei.gonglei
@ 2014-04-01 0:42 ` Michael R. Hines
2014-04-01 1:47 ` Gonglei (Arei)
2014-05-09 4:25 ` Gonglei (Arei)
0 siblings, 2 replies; 9+ messages in thread
From: Michael R. Hines @ 2014-04-01 0:42 UTC (permalink / raw)
To: arei.gonglei, qemu-devel
Cc: weidong.huang, quintela, dgilbert, owasserm, mrhines, pbonzini,
Mo Yuxiang
On 03/29/2014 03:39 PM, arei.gonglei@huawei.com wrote:
> From: Mo Yuxiang <Moyuxiang@huawei.com>
>
> If the networking break or there's something wrong with rdma
> device(ib0 with no IP) during rdma migration, the main_loop of
> qemu will be blocked in rdma_destroy_id. I add rdma_ack_cm_event
> to fix this bug.
>
> Signed-off-by: Mo Yuxiang <Moyuxiang@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> migration-rdma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/migration-rdma.c b/migration-rdma.c
> index eeb4302..f60749b 100644
> --- a/migration-rdma.c
> +++ b/migration-rdma.c
> @@ -949,6 +949,7 @@ route:
> ERROR(errp, "result not equal to event_addr_resolved %s",
> rdma_event_str(cm_event->event));
> perror("rdma_resolve_addr");
> + rdma_ack_cm_event(cm_event);
> ret = -EINVAL;
> goto err_resolve_get_addr;
> }
Reviewed-by: Michael R. Hines <mrhines@us.ibm.com>
Good catch. =) That's an obvious bug. It looks like I need
to do a much better job of "kill -9" inside the regression
testing scripts - probably i should try killing the migration
prematurely at different periods just to be sure there are
no more places where the connection state is not getting
cleaned up......
- Michael
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [Qemu-devel] [PATCH] rdma: Fix block during rdma migration
2014-04-01 0:42 ` Michael R. Hines
@ 2014-04-01 1:47 ` Gonglei (Arei)
2014-05-09 4:25 ` Gonglei (Arei)
1 sibling, 0 replies; 9+ messages in thread
From: Gonglei (Arei) @ 2014-04-01 1:47 UTC (permalink / raw)
To: Michael R. Hines, qemu-devel@nongnu.org
Cc: Huangweidong (C), quintela@redhat.com, dgilbert@redhat.com,
owasserm@redhat.com, mrhines@us.ibm.com, pbonzini@redhat.com,
Moyuxiang
> > If the networking break or there's something wrong with rdma
> > device(ib0 with no IP) during rdma migration, the main_loop of
> > qemu will be blocked in rdma_destroy_id. I add rdma_ack_cm_event
> > to fix this bug.
> >
> > Signed-off-by: Mo Yuxiang <Moyuxiang@huawei.com>
> > Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> > ---
> > migration-rdma.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/migration-rdma.c b/migration-rdma.c
> > index eeb4302..f60749b 100644
> > --- a/migration-rdma.c
> > +++ b/migration-rdma.c
> > @@ -949,6 +949,7 @@ route:
> > ERROR(errp, "result not equal to event_addr_resolved %s",
> > rdma_event_str(cm_event->event));
> > perror("rdma_resolve_addr");
> > + rdma_ack_cm_event(cm_event);
> > ret = -EINVAL;
> > goto err_resolve_get_addr;
> > }
>
> Reviewed-by: Michael R. Hines <mrhines@us.ibm.com>
>
> Good catch. =) That's an obvious bug. It looks like I need
> to do a much better job of "kill -9" inside the regression
> testing scripts - probably i should try killing the migration
> prematurely at different periods just to be sure there are
> no more places where the connection state is not getting
> cleaned up......
>
Sounds good!
Best regards,
-Gonglei
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [Qemu-devel] [PATCH] rdma: Fix block during rdma migration
2014-04-01 0:42 ` Michael R. Hines
2014-04-01 1:47 ` Gonglei (Arei)
@ 2014-05-09 4:25 ` Gonglei (Arei)
2014-05-15 0:43 ` Michael R. Hines
1 sibling, 1 reply; 9+ messages in thread
From: Gonglei (Arei) @ 2014-05-09 4:25 UTC (permalink / raw)
To: Michael R. Hines, qemu-devel@nongnu.org
Cc: Huangweidong (C), quintela@redhat.com, dgilbert@redhat.com,
owasserm@redhat.com, mrhines@us.ibm.com, pbonzini@redhat.com,
Moyuxiang
Hi,
> -----Original Message-----
> From: Michael R. Hines [mailto:mrhines@linux.vnet.ibm.com]
> Sent: Tuesday, April 01, 2014 8:42 AM
> To: Gonglei (Arei); qemu-devel@nongnu.org
> Cc: Huangweidong (C); quintela@redhat.com; dgilbert@redhat.com;
> owasserm@redhat.com; mrhines@us.ibm.com; Moyuxiang;
> pbonzini@redhat.com
> Subject: Re: [Qemu-devel] [PATCH] rdma: Fix block during rdma migration
>
> On 03/29/2014 03:39 PM, arei.gonglei@huawei.com wrote:
> > From: Mo Yuxiang <Moyuxiang@huawei.com>
> >
> > If the networking break or there's something wrong with rdma
> > device(ib0 with no IP) during rdma migration, the main_loop of
> > qemu will be blocked in rdma_destroy_id. I add rdma_ack_cm_event
> > to fix this bug.
> >
> > Signed-off-by: Mo Yuxiang <Moyuxiang@huawei.com>
> > Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> > ---
> > migration-rdma.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/migration-rdma.c b/migration-rdma.c
> > index eeb4302..f60749b 100644
> > --- a/migration-rdma.c
> > +++ b/migration-rdma.c
> > @@ -949,6 +949,7 @@ route:
> > ERROR(errp, "result not equal to event_addr_resolved %s",
> > rdma_event_str(cm_event->event));
> > perror("rdma_resolve_addr");
> > + rdma_ack_cm_event(cm_event);
> > ret = -EINVAL;
> > goto err_resolve_get_addr;
> > }
>
> Reviewed-by: Michael R. Hines <mrhines@us.ibm.com>
>
> Good catch. =) That's an obvious bug. It looks like I need
> to do a much better job of "kill -9" inside the regression
> testing scripts - probably i should try killing the migration
> prematurely at different periods just to be sure there are
> no more places where the connection state is not getting
> cleaned up......
>
> - Michael
>
Michael, do you have a plan to pull this patch to master? Thanks.
Best regards,
-Gonglei
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [Qemu-devel] [PATCH] rdma: Fix block during rdma migration
2014-05-09 4:25 ` Gonglei (Arei)
@ 2014-05-15 0:43 ` Michael R. Hines
2014-05-15 6:47 ` Gonglei (Arei)
2014-05-15 10:08 ` Juan Quintela
0 siblings, 2 replies; 9+ messages in thread
From: Michael R. Hines @ 2014-05-15 0:43 UTC (permalink / raw)
To: Gonglei (Arei), qemu-devel@nongnu.org
Cc: Huangweidong (C), quintela@redhat.com, dgilbert@redhat.com,
owasserm@redhat.com, mrhines@us.ibm.com, Moyuxiang,
pbonzini@redhat.com
On 05/09/2014 12:25 PM, Gonglei (Arei) wrote:
> Hi,
>
>> -----Original Message-----
>> From: Michael R. Hines [mailto:mrhines@linux.vnet.ibm.com]
>> Sent: Tuesday, April 01, 2014 8:42 AM
>> To: Gonglei (Arei); qemu-devel@nongnu.org
>> Cc: Huangweidong (C); quintela@redhat.com; dgilbert@redhat.com;
>> owasserm@redhat.com; mrhines@us.ibm.com; Moyuxiang;
>> pbonzini@redhat.com
>> Subject: Re: [Qemu-devel] [PATCH] rdma: Fix block during rdma migration
>>
>> On 03/29/2014 03:39 PM, arei.gonglei@huawei.com wrote:
>>> From: Mo Yuxiang <Moyuxiang@huawei.com>
>>>
>>> If the networking break or there's something wrong with rdma
>>> device(ib0 with no IP) during rdma migration, the main_loop of
>>> qemu will be blocked in rdma_destroy_id. I add rdma_ack_cm_event
>>> to fix this bug.
>>>
>>> Signed-off-by: Mo Yuxiang <Moyuxiang@huawei.com>
>>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>>> ---
>>> migration-rdma.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/migration-rdma.c b/migration-rdma.c
>>> index eeb4302..f60749b 100644
>>> --- a/migration-rdma.c
>>> +++ b/migration-rdma.c
>>> @@ -949,6 +949,7 @@ route:
>>> ERROR(errp, "result not equal to event_addr_resolved %s",
>>> rdma_event_str(cm_event->event));
>>> perror("rdma_resolve_addr");
>>> + rdma_ack_cm_event(cm_event);
>>> ret = -EINVAL;
>>> goto err_resolve_get_addr;
>>> }
>> Reviewed-by: Michael R. Hines <mrhines@us.ibm.com>
>>
>> Good catch. =) That's an obvious bug. It looks like I need
>> to do a much better job of "kill -9" inside the regression
>> testing scripts - probably i should try killing the migration
>> prematurely at different periods just to be sure there are
>> no more places where the connection state is not getting
>> cleaned up......
>>
>> - Michael
>>
> Michael, do you have a plan to pull this patch to master? Thanks.
>
> Best regards,
> -Gonglei
>
Sorry for the late reply, but I'm not the maintainer for migration,
that's Juan
(I can only signoff on patches like everyone else =).
I also have outstanding RDMA patches myself that have not yet been pulled.
Would you mind pinging Juan for both of us?
- Michael
- Michael
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [Qemu-devel] [PATCH] rdma: Fix block during rdma migration
2014-05-15 0:43 ` Michael R. Hines
@ 2014-05-15 6:47 ` Gonglei (Arei)
2014-05-15 10:08 ` Juan Quintela
1 sibling, 0 replies; 9+ messages in thread
From: Gonglei (Arei) @ 2014-05-15 6:47 UTC (permalink / raw)
To: Michael R. Hines, qemu-devel@nongnu.org
Cc: Huangweidong (C), quintela@redhat.com, dgilbert@redhat.com,
owasserm@redhat.com, mrhines@us.ibm.com, Moyuxiang,
pbonzini@redhat.com
> -----Original Message-----
> From: Michael R. Hines [mailto:mrhines@linux.vnet.ibm.com]
> Sent: Thursday, May 15, 2014 8:44 AM
> To: Gonglei (Arei); qemu-devel@nongnu.org
> Cc: Huangweidong (C); quintela@redhat.com; dgilbert@redhat.com;
> owasserm@redhat.com; mrhines@us.ibm.com; pbonzini@redhat.com;
> Moyuxiang
> Subject: Re: [Qemu-devel] [PATCH] rdma: Fix block during rdma migration
>
> On 05/09/2014 12:25 PM, Gonglei (Arei) wrote:
> > Hi,
> >
> >> -----Original Message-----
> >> From: Michael R. Hines [mailto:mrhines@linux.vnet.ibm.com]
> >> Sent: Tuesday, April 01, 2014 8:42 AM
> >> To: Gonglei (Arei); qemu-devel@nongnu.org
> >> Cc: Huangweidong (C); quintela@redhat.com; dgilbert@redhat.com;
> >> owasserm@redhat.com; mrhines@us.ibm.com; Moyuxiang;
> >> pbonzini@redhat.com
> >> Subject: Re: [Qemu-devel] [PATCH] rdma: Fix block during rdma migration
> >>
> >> On 03/29/2014 03:39 PM, arei.gonglei@huawei.com wrote:
> >>> From: Mo Yuxiang <Moyuxiang@huawei.com>
> >>>
> >>> If the networking break or there's something wrong with rdma
> >>> device(ib0 with no IP) during rdma migration, the main_loop of
> >>> qemu will be blocked in rdma_destroy_id. I add rdma_ack_cm_event
> >>> to fix this bug.
> >>>
> >>> Signed-off-by: Mo Yuxiang <Moyuxiang@huawei.com>
> >>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> >>> ---
> >>> migration-rdma.c | 1 +
> >>> 1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/migration-rdma.c b/migration-rdma.c
> >>> index eeb4302..f60749b 100644
> >>> --- a/migration-rdma.c
> >>> +++ b/migration-rdma.c
> >>> @@ -949,6 +949,7 @@ route:
> >>> ERROR(errp, "result not equal to event_addr_resolved %s",
> >>> rdma_event_str(cm_event->event));
> >>> perror("rdma_resolve_addr");
> >>> + rdma_ack_cm_event(cm_event);
> >>> ret = -EINVAL;
> >>> goto err_resolve_get_addr;
> >>> }
> >> Reviewed-by: Michael R. Hines <mrhines@us.ibm.com>
> >>
> >> Good catch. =) That's an obvious bug. It looks like I need
> >> to do a much better job of "kill -9" inside the regression
> >> testing scripts - probably i should try killing the migration
> >> prematurely at different periods just to be sure there are
> >> no more places where the connection state is not getting
> >> cleaned up......
> >>
> >> - Michael
> >>
> > Michael, do you have a plan to pull this patch to master? Thanks.
> >
> > Best regards,
> > -Gonglei
> >
>
> Sorry for the late reply, but I'm not the maintainer for migration,
> that's Juan
> (I can only signoff on patches like everyone else =).
>
> I also have outstanding RDMA patches myself that have not yet been pulled.
>
> Would you mind pinging Juan for both of us?
>
Thanks.
The patch is Cc'ing Juan, maybe he is very busy.
I have post v2 even, but I have not gotten any reply.
I have no idea how to do next.
Best regards,
-Gonglei
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [Qemu-devel] [PATCH] rdma: Fix block during rdma migration
2014-05-15 0:43 ` Michael R. Hines
2014-05-15 6:47 ` Gonglei (Arei)
@ 2014-05-15 10:08 ` Juan Quintela
1 sibling, 0 replies; 9+ messages in thread
From: Juan Quintela @ 2014-05-15 10:08 UTC (permalink / raw)
To: Michael R. Hines
Cc: Huangweidong (C), qemu-devel@nongnu.org, dgilbert@redhat.com,
owasserm@redhat.com, Gonglei (Arei), mrhines@us.ibm.com,
Moyuxiang, pbonzini@redhat.com
"Michael R. Hines" <mrhines@linux.vnet.ibm.com> wrote:
> On 05/09/2014 12:25 PM, Gonglei (Arei) wrote:
>> Hi,
>>
>>> -----Original Message-----
>>> From: Michael R. Hines [mailto:mrhines@linux.vnet.ibm.com]
>>> Sent: Tuesday, April 01, 2014 8:42 AM
>>> To: Gonglei (Arei); qemu-devel@nongnu.org
>>> Cc: Huangweidong (C); quintela@redhat.com; dgilbert@redhat.com;
>>> owasserm@redhat.com; mrhines@us.ibm.com; Moyuxiang;
>>> pbonzini@redhat.com
>>> Subject: Re: [Qemu-devel] [PATCH] rdma: Fix block during rdma migration
>>>
>>> On 03/29/2014 03:39 PM, arei.gonglei@huawei.com wrote:
>>>> From: Mo Yuxiang <Moyuxiang@huawei.com>
>>>>
>>>> If the networking break or there's something wrong with rdma
>>>> device(ib0 with no IP) during rdma migration, the main_loop of
>>>> qemu will be blocked in rdma_destroy_id. I add rdma_ack_cm_event
>>>> to fix this bug.
>>>>
>>>> Signed-off-by: Mo Yuxiang <Moyuxiang@huawei.com>
>>>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>>>> ---
>>>> migration-rdma.c | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/migration-rdma.c b/migration-rdma.c
>>>> index eeb4302..f60749b 100644
>>>> --- a/migration-rdma.c
>>>> +++ b/migration-rdma.c
>>>> @@ -949,6 +949,7 @@ route:
>>>> ERROR(errp, "result not equal to event_addr_resolved %s",
>>>> rdma_event_str(cm_event->event));
>>>> perror("rdma_resolve_addr");
>>>> + rdma_ack_cm_event(cm_event);
>>>> ret = -EINVAL;
>>>> goto err_resolve_get_addr;
>>>> }
>>> Reviewed-by: Michael R. Hines <mrhines@us.ibm.com>
>>>
>>> Good catch. =) That's an obvious bug. It looks like I need
>>> to do a much better job of "kill -9" inside the regression
>>> testing scripts - probably i should try killing the migration
>>> prematurely at different periods just to be sure there are
>>> no more places where the connection state is not getting
>>> cleaned up......
>>>
>>> - Michael
>>>
>> Michael, do you have a plan to pull this patch to master? Thanks.
>>
>> Best regards,
>> -Gonglei
>>
>
> Sorry for the late reply, but I'm not the maintainer for migration,
> that's Juan
> (I can only signoff on patches like everyone else =).
>
> I also have outstanding RDMA patches myself that have not yet been pulled.
>
> Would you mind pinging Juan for both of us?
Pointer, please?
I was waiting for Michael Reviewed-by from Michael.
Later, Juan.
>
> - Michael
>
> - Michael
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Qemu-devel] [PATCH] rdma: Fix block during rdma migration
@ 2014-03-17 1:45 Wangyufei (James)
0 siblings, 0 replies; 9+ messages in thread
From: Wangyufei (James) @ 2014-03-17 1:45 UTC (permalink / raw)
To: qemu-devel@nongnu.org
Cc: Zhaoyanbin (A), quintela@redhat.com, qemu-stable@nongnu.org,
Wangrui (K), Michael R Hines
>From 1b02d80679a776791765b720bea21de6fe650252 Mon Sep 17 00:00:00 2001
From: Wang Yufei <james.wangyufei@huawei.com>
Date: Fri, 14 Mar 2014 01:41:13 +0000
Subject: [PATCH] rdma: Fix block during rdma migration
If the networking break or there's something wrong with rdma
device(ib0 with no IP) during rdma migration, the main_loop of
qemu will be blocked in rdma_destroy_id. I add rdma_ack_cm_event
to fix this bug.
Signed-off-by: Wang Yufei <james.wangyufei@huawei.com>
---
migration-rdma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration-rdma.c b/migration-rdma.c
index eeb4302..f60749b 100644
--- a/migration-rdma.c
+++ b/migration-rdma.c
@@ -949,6 +949,7 @@ route:
ERROR(errp, "result not equal to event_addr_resolved %s",
rdma_event_str(cm_event->event));
perror("rdma_resolve_addr");
+ rdma_ack_cm_event(cm_event);
ret = -EINVAL;
goto err_resolve_get_addr;
}
--
1.7.12.4
Best Regards,
-WangYufei
^ permalink raw reply related [flat|nested] 9+ messages in thread* [Qemu-devel] [PATCH] rdma: Fix block during rdma migration
@ 2014-03-14 1:42 Wangyufei (James)
0 siblings, 0 replies; 9+ messages in thread
From: Wangyufei (James) @ 2014-03-14 1:42 UTC (permalink / raw)
To: qemu-devel@nongnu.org; +Cc: Zhaoyanbin (A), Wangrui (K)
>From 1b02d80679a776791765b720bea21de6fe650252 Mon Sep 17 00:00:00 2001
From: Wang Yufei <james.wangyufei@huawei.com>
Date: Fri, 14 Mar 2014 01:41:13 +0000
Subject: [PATCH] rdma: Fix block during rdma migration
If the networking break or there's something wrong with rdma
device(ib0 with no IP) during rdma migration, the main_loop of
qemu will be blocked in rdma_destroy_id. I add rdma_ack_cm_event
to fix this bug.
Signed-off-by: Wang Yufei <james.wangyufei@huawei.com>
---
migration-rdma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration-rdma.c b/migration-rdma.c
index eeb4302..f60749b 100644
--- a/migration-rdma.c
+++ b/migration-rdma.c
@@ -949,6 +949,7 @@ route:
ERROR(errp, "result not equal to event_addr_resolved %s",
rdma_event_str(cm_event->event));
perror("rdma_resolve_addr");
+ rdma_ack_cm_event(cm_event);
ret = -EINVAL;
goto err_resolve_get_addr;
}
--
1.7.12.4
Best Regards,
-WangYufei
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-05-15 10:08 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-29 7:39 [Qemu-devel] [PATCH] rdma: Fix block during rdma migration arei.gonglei
2014-04-01 0:42 ` Michael R. Hines
2014-04-01 1:47 ` Gonglei (Arei)
2014-05-09 4:25 ` Gonglei (Arei)
2014-05-15 0:43 ` Michael R. Hines
2014-05-15 6:47 ` Gonglei (Arei)
2014-05-15 10:08 ` Juan Quintela
-- strict thread matches above, loose matches on Subject: below --
2014-03-17 1:45 Wangyufei (James)
2014-03-14 1:42 Wangyufei (James)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).