From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36470)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WkvZN-0004hh-OT
	for qemu-devel@nongnu.org; Thu, 15 May 2014 09:19:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WkvZC-00064g-AK
	for qemu-devel@nongnu.org; Thu, 15 May 2014 09:19:33 -0400
Received: from cantor2.suse.de ([195.135.220.15]:44144 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WkvZC-00063a-4E
	for qemu-devel@nongnu.org; Thu, 15 May 2014 09:19:22 -0400
Message-ID: <5374BED7.50000@suse.de>
Date: Thu, 15 May 2014 15:19:19 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1398876525-28831-1-git-send-email-ehabkost@redhat.com>
	<1398876525-28831-4-git-send-email-ehabkost@redhat.com>
In-Reply-To: <1398876525-28831-4-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 03/18] target-i386: Merge feature
 filtering/checking functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>, Marcelo Tosatti <mtosatti@redhat.com>, Aurelien Jarno <aurelien@aurel32.net>, Igor Mammedov <imammedo@redhat.com>

Am 30.04.2014 18:48, schrieb Eduardo Habkost:
> Merge filter_features_for_kvm() and kvm_check_features_against_host().
>=20
> Both functions made exactly the same calculations, the only difference
> was that filter_features_for_kvm() changed the bits on cpu->features[],
> and kvm_check_features_against_host() did error reporting.
>=20
> Reviewed-by: Richard Henderson <rth@twiddle.net>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

Applying minor style tweak towards gtk-doc:

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 6302a5c..f022ef3 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1819,11 +1819,12 @@ CpuDefinitionInfoList
*arch_query_cpu_definitions(Error **errp)
     return cpu_list;
 }

-/* Filters CPU feature words based on host availability of each feature
- *
- * Returns 0 if all flags are supported by the host, non-zero otherwise.
+/*
+ * Filters CPU feature words based on host availability of each feature.
  *
  * This function may be called only if KVM is enabled.
+ *
+ * Returns: 0 if all flags are supported by the host, non-zero otherwise=
.
  */
 static int filter_features_for_kvm(X86CPU *cpu)
 {

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg