From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkxFy-0004JH-CZ for qemu-devel@nongnu.org; Thu, 15 May 2014 11:07:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkxFt-0006Dp-FL for qemu-devel@nongnu.org; Thu, 15 May 2014 11:07:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39829) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkxFt-0006Dh-8a for qemu-devel@nongnu.org; Thu, 15 May 2014 11:07:33 -0400 Message-ID: <5374D830.7040000@redhat.com> Date: Thu, 15 May 2014 09:07:28 -0600 From: Eric Blake MIME-Version: 1.0 References: <53efdb963d57e99fd0f77a34b1d3a860b3f6d2aa.1400123059.git.jcody@redhat.com> In-Reply-To: <53efdb963d57e99fd0f77a34b1d3a860b3f6d2aa.1400123059.git.jcody@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qbUEpmoohPl6geJMoCmwXu0dSR4LpJkxh" Subject: Re: [Qemu-devel] [PATCH 3/5] block: make 'top' argument to block-commit optional List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , qemu-devel@nongnu.org Cc: kwolf@redhat.com, benoit.canet@irqsave.net, pkrempa@redhat.com, famz@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qbUEpmoohPl6geJMoCmwXu0dSR4LpJkxh Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/14/2014 09:20 PM, Jeff Cody wrote: > Now that active layer block-commit is supported, the 'top' argument > no longer needs to be mandatory. >=20 > Change it optional, with the default being the active layer in the > device chain. Good, this is an API-compatible change (doesn't break old clients that always provide 'top'). I'm definitely in favor of it. >=20 > Signed-off-by: Jeff Cody > --- > blockdev.c | 3 ++- > qapi-schema.json | 7 ++++--- > qmp-commands.hx | 5 +++-- > tests/qemu-iotests/040 | 28 ++++++++++++++++++---------- > 4 files changed, 27 insertions(+), 16 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -2099,8 +2099,9 @@ > # @base: #optional The file name of the backing image to write data = into. > # If not specified, this is the deepest backing ima= ge > # > -# @top: The file name of the backing image within the ima= ge chain, > -# which contains the topmost data to be committed d= own. > +# @top: #optional The file name of the backing image within the ima= ge chain, > +# which contains the topmost data to be committed d= own. If > +# not specified, this is the active layer. We have not done the conversion from mandatory to optional very often; I wonder if it is worth an annotation of when the conversion happened (so someone reading just this version of the schema but planning on targeting older qemu knows to always supply the argument). Something lik= e: @top: since 1.3, #optional since 2.1; The file name... But that feels rather long. It's not a show-stopper to me, particularly since we still don't have any automated conversion from these comments into any other documentation formats. That is, if we decide it is worth adding hints about when something changed from mandatory to optional, it would be its own patch and cover the work we've done on other recent changes like block_passwd. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --qbUEpmoohPl6geJMoCmwXu0dSR4LpJkxh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTdNgwAAoJEKeha0olJ0Nq7WcH/RJUapYv2Hn5I9B/uQLkfZF1 vEd9Dh6iVoj3D2bGoo3kDUV1zPdFrdDvfgF7TTywb6FJrT3IeACjCFCmCqsFJIEx B8+Zh8hKlX0SG1ruc7zx1Fu9Gez+s82aseDrekzdWQ0JlEVCAuPRg9t8CJNJCMhU sOstX24Ay1iTEX4xam6bq39GR1X75nimDmHVyYwYY3qkBbH2NNXMPuPt1NYzBYMI UPYBHvcUfBUC5TI+sDGlzs4sWBFvjoKSJOGRJ870mQ+vQfVM2LWi5nIhV4LEWo92 B1M7jnnT6+e6nxhno3RlVdAXmU7U6/fR3OMdyVygt9TUGG5EPrYfEPK/FFYDjgM= =6bTq -----END PGP SIGNATURE----- --qbUEpmoohPl6geJMoCmwXu0dSR4LpJkxh--