From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WkzET-0002sW-Bm for qemu-devel@nongnu.org; Thu, 15 May 2014 13:14:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WkzEN-000855-7K for qemu-devel@nongnu.org; Thu, 15 May 2014 13:14:13 -0400 Message-ID: <5374F5B5.3050101@redhat.com> Date: Thu, 15 May 2014 19:13:25 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1399473780-20374-1-git-send-email-marcel.a@redhat.com> <1399473780-20374-4-git-send-email-marcel.a@redhat.com> <87ha4rqapw.fsf@blackfin.pond.sub.org> <5374ED83.4030909@suse.de> In-Reply-To: <5374ED83.4030909@suse.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/4] vl.c: do not set 'type' property in obj_set_property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= , Markus Armbruster , Marcel Apfelbaum Cc: mst@redhat.com, aik@ozlabs.ru, qemu-devel@nongnu.org, lcapitulino@redhat.com, blauwirbel@gmail.com, jcmvbkbc@gmail.com, edgar.iglesias@gmail.com, gxt@mprc.pku.edu.cn, proljc@gmail.com, agraf@suse.de, scottwood@freescale.com, borntraeger@de.ibm.com, hpoussin@reactos.org, aliguori@amazon.com, lersek@redhat.com, mdroth@linux.vnet.ibm.com, chouteau@adacore.com, jan.kiszka@web.de, stefanha@redhat.com, cornelia.huck@de.ibm.com, peter.crosthwaite@xilinx.com, mark.langsdorf@calxeda.com, michael@walle.cc, qemu-ppc@nongnu.org, peter.chubb@nicta.com.au, aurelien@aurel32.net Il 15/05/2014 18:38, Andreas F=E4rber ha scritto: > On that matter, our help output does not seem to indicate the name of > the corresponding -object parameter, my unverified guess is that that i= s > called "qom-type". > > OTOH there's no reason to suppress "qom-type" or "id" for -machine, as > implied when I suggested using a separate function. "id" should be suppressed for backwards compatibility for "-machine id=3D= foo". "qom-type" is not needed indeed. But it is so ugly that I would suggest=20 doing a backwards-incompatible change to the name the default argument=20 of -object, from "qom-type" to "type". Libvirt doesn't use "qom-type",=20 and "type" nicely matches the QOM property name: $ qemu-system-x86_64 -qmp unix:/tmp/m1,server,nowait -S \ -object rng-random,id=3Dfoo & $ ./qom-get -s /tmp/m1 /objects/foo.type rng-random Paolo