From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wl06r-0002Xc-5L for qemu-devel@nongnu.org; Thu, 15 May 2014 14:10:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wl06k-0002gr-S1 for qemu-devel@nongnu.org; Thu, 15 May 2014 14:10:25 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50814 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wl06k-0002eZ-Mp for qemu-devel@nongnu.org; Thu, 15 May 2014 14:10:18 -0400 Message-ID: <53750308.9030809@suse.de> Date: Thu, 15 May 2014 20:10:16 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1398876525-28831-1-git-send-email-ehabkost@redhat.com> <1398876525-28831-8-git-send-email-ehabkost@redhat.com> In-Reply-To: <1398876525-28831-8-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 07/18] target-i386: Filter FEAT_7_0_EBX TCG features too List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Marcelo Tosatti , Igor Mammedov , Paolo Bonzini , Aurelien Jarno , Richard Henderson Am 30.04.2014 18:48, schrieb Eduardo Habkost: > The TCG_7_0_EBX_FEATURES macro was defined but never used (it even had = a > typo that was never noticed). Make the existing TCG feature filtering > code use it. >=20 > Change the TCG feature flag filtering code to use it. Sentence seems duplicate - which one to keep? Should we CC this commit for -stable? (Affects -cpu Haswell probably?) If not, should we make this conditional on the machine version? One off-topic question below... >=20 > Reviewed-by: Richard Henderson > Signed-off-by: Eduardo Habkost > --- > Changes v1 -> v2: > * Trivial rebase to latest qom-cpu (commit 90c5d39c) > (Reviewed-by line kept) > Changes v2 -> v3: > * Trivial rebase after QEMU 2.0 (onto commit 2d03b49) > (Reviewed-by line kept) > --- > target-i386/cpu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index bbac5fc..714d121 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -588,7 +588,7 @@ struct X86CPUDefinition { > #define TCG_EXT3_FEATURES (CPUID_EXT3_LAHF_LM | CPUID_EXT3_SVM | \ > CPUID_EXT3_CR8LEG | CPUID_EXT3_ABM | CPUID_EXT3_SSE4A) > #define TCG_SVM_FEATURES 0 > -#define TCG_7_0_EBX_FEATURES (CPUID_7_0_EBX_SMEP | CPUID_7_0_EBX_SMAP = \ > +#define TCG_7_0_EBX_FEATURES (CPUID_7_0_EBX_SMEP | CPUID_7_0_EBX_SMAP = | \ > CPUID_7_0_EBX_BMI1 | CPUID_7_0_EBX_BMI2 | CPUID_7_0_EBX_ADX) > /* missing: > CPUID_7_0_EBX_FSGSBASE, CPUID_7_0_EBX_HLE, CPUID_7_0_EBX_AVX= 2, > @@ -2596,6 +2596,7 @@ static void x86_cpu_realizefn(DeviceState *dev, E= rror **errp) > if (!kvm_enabled()) { Is there a patch or should I follow-up with one to make TCG filtering conditional to if (tcg_enabled())? (Xen, QTest) Regards, Andreas > env->features[FEAT_1_EDX] &=3D TCG_FEATURES; > env->features[FEAT_1_ECX] &=3D TCG_EXT_FEATURES; > + env->features[FEAT_7_0_EBX] &=3D TCG_7_0_EBX_FEATURES; > env->features[FEAT_8000_0001_EDX] &=3D TCG_EXT2_FEATURES; > env->features[FEAT_8000_0001_ECX] &=3D TCG_EXT3_FEATURES; > env->features[FEAT_SVM] &=3D TCG_SVM_FEATURES; --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg