From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] iotests: Use configured python
Date: Thu, 15 May 2014 13:23:19 -0600 [thread overview]
Message-ID: <53751427.4090300@redhat.com> (raw)
In-Reply-To: <87r43v0wsk.fsf@blackfin.pond.sub.org>
[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]
On 05/15/2014 11:35 AM, Markus Armbruster wrote:
>
> The root stupid idea is to run stuff in the source tree. Since a source
> tree can have many build trees, finding the correct build tree can't be
> automated.
>
> If you run stuff in the build tree, there is exactly one source tree,
> and putting a pointer to it in the build tree is trivial. In fact, we
> already have one: try "make -pn | grep ^SRC_PATH".
>
> I'd generate a suitable script into the build tree that sets up
> necessary variables, then sources $SRC_PATH/qemu-iotests/check.
In fact, this is sort of what libvirt does. We have a 'run.in' script
template at the top directory, then create 'run' in the build tree
(whether or not it is a VPATH tree); the run script then primes any
necessary environment variables to execute commands using the build tree
as its preferred location for executables, dynamic libraries, and helper
files.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2014-05-15 19:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-03 14:47 [Qemu-devel] [PATCH] iotests: Use configured python Max Reitz
2014-05-05 12:26 ` Stefan Hajnoczi
2014-05-05 13:08 ` Peter Maydell
2014-05-05 14:02 ` Eric Blake
2014-05-05 16:25 ` Max Reitz
2014-05-05 16:35 ` Eric Blake
2014-05-06 10:23 ` Stefan Hajnoczi
2014-05-13 15:08 ` Kevin Wolf
2014-05-14 12:33 ` Markus Armbruster
2014-05-14 23:41 ` Max Reitz
2014-05-15 2:02 ` Fam Zheng
2014-05-15 6:52 ` Markus Armbruster
2014-05-15 8:12 ` Markus Armbruster
2014-05-15 16:56 ` Max Reitz
2014-05-15 17:08 ` Peter Maydell
2014-05-15 17:29 ` Max Reitz
2014-05-15 17:33 ` Peter Maydell
2014-05-15 17:35 ` Markus Armbruster
2014-05-15 17:41 ` Max Reitz
2014-05-15 19:23 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53751427.4090300@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).