From: Eric Blake <eblake@redhat.com>
To: "Luiz Capitulino" <lcapitulino@redhat.com>,
"Benoît Canet" <benoit.canet@irqsave.net>
Cc: armbru@redhat.com, Benoit Canet <benoit@irqsave.net>,
qemu-devel@nongnu.org, vilanova@ac.upc.edu
Subject: Re: [Qemu-devel] [PATCH v3] qapi: skip redundant includes
Date: Thu, 15 May 2014 13:39:02 -0600 [thread overview]
Message-ID: <537517D6.2070601@redhat.com> (raw)
In-Reply-To: <20140515151337.735d886d@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]
On 05/15/2014 01:13 PM, Luiz Capitulino wrote:
> On Wed, 14 May 2014 16:07:49 +0200
> Benoît Canet <benoit.canet@irqsave.net> wrote:
>
>> The purpose of this change is to help create a json file containing
>> common definitions; each bit of generated C code must be emitted
>> only one time.
>>
>> A second history global to all QAPISchema instances has been added
>> to detect when a file is included more than one time and skip these
>> includes.
>> It does not act as a stack and the changes made to it by the
>> __init__ function are propagated back to the caller so it's really
>> a global state.
>
> Shouldn't this behavior be noted somewhere? Eg. in writing-qmp-commands.txt
> or qapi-code-gen.txt?
dosc/qapi-code-gen.txt already covers the {'include':'file'} syntax, so
yes, that should be updated to mention that multiple includes of the
same file are now safe.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-05-15 19:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 14:07 [Qemu-devel] [PATCH v3] Let the C generated bits of QAPI be generated only once when identical includes are done Benoît Canet
2014-05-14 14:07 ` [Qemu-devel] [PATCH v3] qapi: skip redundant includes Benoît Canet
2014-05-14 15:04 ` Eric Blake
2014-05-15 19:13 ` Luiz Capitulino
2014-05-15 19:39 ` Eric Blake [this message]
2014-05-15 20:03 ` Benoît Canet
-- strict thread matches above, loose matches on Subject: below --
2014-06-27 13:41 [Qemu-devel] [PATCH v3] Let the C generated bits of QAPI be generated only once when identical includes are done Benoît Canet
2014-06-27 13:41 ` [Qemu-devel] [PATCH v3] qapi: skip redundant includes Benoît Canet
2014-06-27 15:14 ` Markus Armbruster
2014-06-27 15:28 ` Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537517D6.2070601@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=benoit@irqsave.net \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).