From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wl1Um-0003G4-RR for qemu-devel@nongnu.org; Thu, 15 May 2014 15:39:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wl1Ui-0000bF-62 for qemu-devel@nongnu.org; Thu, 15 May 2014 15:39:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31016) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wl1Uh-0000b2-T7 for qemu-devel@nongnu.org; Thu, 15 May 2014 15:39:08 -0400 Message-ID: <537517D6.2070601@redhat.com> Date: Thu, 15 May 2014 13:39:02 -0600 From: Eric Blake MIME-Version: 1.0 References: <1400076469-5914-1-git-send-email-benoit.canet@irqsave.net> <1400076469-5914-2-git-send-email-benoit.canet@irqsave.net> <20140515151337.735d886d@redhat.com> In-Reply-To: <20140515151337.735d886d@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bplqTjFDlsIufq2lA7nbLVjLshGlflOWL" Subject: Re: [Qemu-devel] [PATCH v3] qapi: skip redundant includes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino , =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: armbru@redhat.com, Benoit Canet , qemu-devel@nongnu.org, vilanova@ac.upc.edu This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --bplqTjFDlsIufq2lA7nbLVjLshGlflOWL Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/15/2014 01:13 PM, Luiz Capitulino wrote: > On Wed, 14 May 2014 16:07:49 +0200 > Beno=C3=AEt Canet wrote: >=20 >> The purpose of this change is to help create a json file containing >> common definitions; each bit of generated C code must be emitted >> only one time. >> >> A second history global to all QAPISchema instances has been added >> to detect when a file is included more than one time and skip these >> includes. >> It does not act as a stack and the changes made to it by the >> __init__ function are propagated back to the caller so it's really >> a global state. >=20 > Shouldn't this behavior be noted somewhere? Eg. in writing-qmp-commands= =2Etxt > or qapi-code-gen.txt? dosc/qapi-code-gen.txt already covers the {'include':'file'} syntax, so yes, that should be updated to mention that multiple includes of the same file are now safe. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --bplqTjFDlsIufq2lA7nbLVjLshGlflOWL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTdRfWAAoJEKeha0olJ0NqT2IIAKBsRsFeBBFAeKvZrcH7RGpT 1n113HOf/Rf+PeZecmuXmahzimuaRTvw1PngMzjmRUlef2Hz38zRe+EoZsYtqR4e SuyfULp+pe5pepG3vQtqxLi5Z7BHLZg6eZG304/VtJbdsPaxTDxFLTNybZpOM2/3 8LoRk570ZZRgPdi+SQU74rhWQSrFk9j1PRPxe3ljHCiVFHE2cj9Am3ivNRU7pwx3 uzNuuxSi1W8Y3FOYQwaHtkJrAKAthPdo5IHWt1FWKrM67Yd+qa0H252Sd7Q6O0Np MsxycpkRDzyFMFfpTKsM8dhopzMRcW8qTkHFgJ4/xJyp+VTE+L8J7vPFr2InRms= =Y5wg -----END PGP SIGNATURE----- --bplqTjFDlsIufq2lA7nbLVjLshGlflOWL--