From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] target-i386: fix segment flags for SMM and VM86 mode
Date: Fri, 16 May 2014 09:33:57 +0200 [thread overview]
Message-ID: <5375BF65.1070301@redhat.com> (raw)
In-Reply-To: <20140515184530.GB22225@morn.localdomain>
Il 15/05/2014 20:45, Kevin O'Connor ha scritto:
> On Thu, May 15, 2014 at 06:56:54PM +0200, Paolo Bonzini wrote:
>> With the next patch, these need to be correct or VM86 tasks
>> have the wrong CPL. The flags are basically what the Intel VMX
>> documentation say is mandatory for entry into a VM86 guest.
>>
>> For consistency, SMM ought to have the same flags except with
>> CPL=0.
>
> Does cpu_x86_load_seg() and x86_cpu_gdb_load_seg() then also have to
> change?
The former is just for user-mode emulation, but it probably doesn't hurt
to fix it (I just found out about tests/tcg/runcom.c, which can be used
to test this code path). For the latter you're right, thanks!
Paolo
next prev parent reply other threads:[~2014-05-16 7:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 16:56 [Qemu-devel] [PATCH 0/3] target-i386: fix CPL computation Paolo Bonzini
2014-05-15 16:56 ` [Qemu-devel] [PATCH 1/3] target-i386: fix segment flags for SMM and VM86 mode Paolo Bonzini
2014-05-15 18:45 ` Kevin O'Connor
2014-05-16 7:33 ` Paolo Bonzini [this message]
2014-05-15 16:56 ` [Qemu-devel] [PATCH 2/3] target-i386: prepare CPL checks for next patch Paolo Bonzini
2014-05-15 16:56 ` [Qemu-devel] [PATCH 3/3] target-i386: get CPL from SS.DPL Paolo Bonzini
2014-05-15 18:38 ` Kevin O'Connor
2014-05-16 7:35 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5375BF65.1070301@redhat.com \
--to=pbonzini@redhat.com \
--cc=kevin@koconnor.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).