From: Paolo Bonzini <pbonzini@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: mdroth@linux.vnet.ibm.com, Amos Kong <akong@redhat.com>,
qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 0/3] qapi: fix coding style in generated code
Date: Fri, 16 May 2014 12:56:37 +0200 [thread overview]
Message-ID: <5375EEE5.6080606@redhat.com> (raw)
In-Reply-To: <20140515150536.1cb402af@redhat.com>
Il 15/05/2014 21:05, Luiz Capitulino ha scritto:
> On Thu, 8 May 2014 09:14:37 +0800
> Amos Kong <akong@redhat.com> wrote:
>
>> Not a serious issue, but it's helpful if we can fix it.
>>
>> V2: split change of scripts/qapi-visit.py to a split patch,
>> eat space by using a special char as Markus suggested
>> V3: update commitlog, update special string, fix of adding
>> const replace string by pattern
>> V4: fix pattern to cleanup special string (Paolo)
>
> Paolo, can you ACK this now?
>
Sure!
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
next prev parent reply other threads:[~2014-05-16 10:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 1:14 [Qemu-devel] [PATCH v4 0/3] qapi: fix coding style in generated code Amos Kong
2014-05-08 1:14 ` [Qemu-devel] [PATCH v4 1/3] qapi: fix coding style in parameters list Amos Kong
2014-05-13 2:57 ` Eric Blake
2014-05-21 2:08 ` Amos Kong
2014-05-08 1:14 ` [Qemu-devel] [PATCH v4 2/3] qapi: add const prefix to 'char *' insider c_type() Amos Kong
2014-05-13 2:59 ` Eric Blake
2014-05-08 1:14 ` [Qemu-devel] [PATCH v4 3/3] qapi: Suppress unwanted space between type and identifier Amos Kong
2014-05-15 19:36 ` Eric Blake
2014-05-15 19:05 ` [Qemu-devel] [PATCH v4 0/3] qapi: fix coding style in generated code Luiz Capitulino
2014-05-16 10:56 ` Paolo Bonzini [this message]
2014-05-16 14:19 ` Luiz Capitulino
2014-05-22 11:57 ` Amos Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5375EEE5.6080606@redhat.com \
--to=pbonzini@redhat.com \
--cc=akong@redhat.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).