From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlGqO-0000eO-RZ for qemu-devel@nongnu.org; Fri, 16 May 2014 08:02:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WlGqK-0007V3-B4 for qemu-devel@nongnu.org; Fri, 16 May 2014 08:02:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlGqK-0007Ux-1T for qemu-devel@nongnu.org; Fri, 16 May 2014 08:02:28 -0400 Message-ID: <5375FE4A.1010807@redhat.com> Date: Fri, 16 May 2014 06:02:18 -0600 From: Eric Blake MIME-Version: 1.0 References: <1400237516-15048-1-git-send-email-benoit.canet@irqsave.net> <1400237516-15048-2-git-send-email-benoit.canet@irqsave.net> In-Reply-To: <1400237516-15048-2-git-send-email-benoit.canet@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="t7oTwa1vkDt0X62H5tFeGXlfTtUg1e0rh" Subject: Re: [Qemu-devel] [PATCH v4] qapi: skip redundant includes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org Cc: armbru@redhat.com, Benoit Canet , vilanova@ac.upc.edu, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --t7oTwa1vkDt0X62H5tFeGXlfTtUg1e0rh Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/16/2014 04:51 AM, Beno=C3=AEt Canet wrote: > The purpose of this change is to help create a json file containing > common definitions; each bit of generated C code must be emitted > only one time. >=20 > A second history global to all QAPISchema instances has been added > to detect when a file is included more than one time and skip these > includes. > It does not act as a stack and the changes made to it by the > __init__ function are propagated back to the caller so it's really > a global state. >=20 > Signed-off-by: Benoit Canet > --- > docs/qapi-code-gen.txt | 2 +- Looks like the only addition. > +++ b/docs/qapi-code-gen.txt > @@ -48,7 +48,7 @@ The QAPI schema definitions can be modularized using = the 'include' directive: > { 'include': 'path/to/file.json'} > =20 > The directive is evaluated recursively, and include paths are relative= to the > -file using the directive. > +file using the directive. Multiple includes of the same file are safe.= Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --t7oTwa1vkDt0X62H5tFeGXlfTtUg1e0rh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTdf5KAAoJEKeha0olJ0NqygcH/1rdWo7v89I0zJDh2VYEgwOe 7JWmP/IElYcBQYqyn+RnwLsckE+Jjfs1AhQSchPTrdrjZ2sYWCGjkRAgCf/Y6cz4 U1bwyfh42TTNMF/Q5EbQbr4MOO+JxDJaq/EVxku4krQ1wv+5pkgiqkNfn5Ow+gel C/PtHRBtmBwLwM2ZukQbLWunMMcDXu7sR4HwZJz+XCnKXb+GGufW++uV6k0vFtB9 s2Y1mSBPIrQP/71JhQk+W7VUqnswojSGbwN1gxvqAUAIemCkQMSRfeYuolokzFbB 5L8l7X4/oWOqwQOrRU9nOw42YgHlgYzhQDBqbYX7qYkiFxc9HRYr6XC/aZJTIXo= =J5S2 -----END PGP SIGNATURE----- --t7oTwa1vkDt0X62H5tFeGXlfTtUg1e0rh--