From: Richard Henderson <rth@twiddle.net>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target-i386: set CC_OP to CC_OP_EFLAGS in cpu_load_eflags
Date: Fri, 16 May 2014 07:51:03 -0700 [thread overview]
Message-ID: <537625D7.1070904@twiddle.net> (raw)
In-Reply-To: <1400232987-8133-1-git-send-email-pbonzini@redhat.com>
On 05/16/2014 02:36 AM, Paolo Bonzini wrote:
> There is no reason to keep that out of the function. The comment refers
> to the disassembler's cc_op state rather than the CPUState field.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> target-i386/cpu.h | 5 ++++-
> target-i386/seg_helper.c | 2 --
> target-i386/smm_helper.c | 2 --
> target-i386/svm_helper.c | 2 --
> 4 files changed, 4 insertions(+), 7 deletions(-)
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
next prev parent reply other threads:[~2014-05-16 14:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 9:36 [Qemu-devel] [PATCH] target-i386: set CC_OP to CC_OP_EFLAGS in cpu_load_eflags Paolo Bonzini
2014-05-16 14:51 ` Richard Henderson [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-05-15 17:04 Paolo Bonzini
2014-05-15 17:30 ` Richard Henderson
2014-05-16 9:34 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537625D7.1070904@twiddle.net \
--to=rth@twiddle.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).