From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlJTd-0007RL-OI for qemu-devel@nongnu.org; Fri, 16 May 2014 10:51:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WlJTX-0007UD-QX for qemu-devel@nongnu.org; Fri, 16 May 2014 10:51:13 -0400 Received: from mail-qg0-x232.google.com ([2607:f8b0:400d:c04::232]:39616) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlJTX-0007U7-Mx for qemu-devel@nongnu.org; Fri, 16 May 2014 10:51:07 -0400 Received: by mail-qg0-f50.google.com with SMTP id z60so4306583qgd.37 for ; Fri, 16 May 2014 07:51:07 -0700 (PDT) Sender: Richard Henderson Message-ID: <537625D7.1070904@twiddle.net> Date: Fri, 16 May 2014 07:51:03 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1400232987-8133-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1400232987-8133-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-i386: set CC_OP to CC_OP_EFLAGS in cpu_load_eflags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org On 05/16/2014 02:36 AM, Paolo Bonzini wrote: > There is no reason to keep that out of the function. The comment refers > to the disassembler's cc_op state rather than the CPUState field. > > Signed-off-by: Paolo Bonzini > --- > target-i386/cpu.h | 5 ++++- > target-i386/seg_helper.c | 2 -- > target-i386/smm_helper.c | 2 -- > target-i386/svm_helper.c | 2 -- > 4 files changed, 4 insertions(+), 7 deletions(-) Reviewed-by: Richard Henderson r~