From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlJgf-0003Bi-VR for qemu-devel@nongnu.org; Fri, 16 May 2014 11:04:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WlJgW-0004P7-Tg for qemu-devel@nongnu.org; Fri, 16 May 2014 11:04:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65406) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlJgW-0004Ok-KM for qemu-devel@nongnu.org; Fri, 16 May 2014 11:04:32 -0400 Message-ID: <537628FC.3070506@redhat.com> Date: Fri, 16 May 2014 09:04:28 -0600 From: Eric Blake MIME-Version: 1.0 References: <1400251247-11218-1-git-send-email-peter@gridcentric.ca> In-Reply-To: <1400251247-11218-1-git-send-email-peter@gridcentric.ca> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="f3xv60dG1Ol6VhAEEXNtQWgPd8BvTgwhk" Subject: Re: [Qemu-devel] [PATCH] doc: add "setup" to list of migration states List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: peter@gridcentric.ca, qemu-devel@nongnu.org Cc: lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --f3xv60dG1Ol6VhAEEXNtQWgPd8BvTgwhk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/16/2014 08:40 AM, peter@gridcentric.ca wrote: > From: Peter Feiner >=20 > On a slow VM (e.g., nested), you see the "setup" state when you query t= he > migration status. >=20 > Signed-off-by: Peter Feiner > --- > qapi-schema.json | 2 +- > qmp-commands.hx | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index 36cb964..f4ffede 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -691,7 +691,7 @@ > # Information about current migration process. > # > # @status: #optional string describing the current migration status. > -# As of 0.14.0 this can be 'active', 'completed', 'failed' or= > +# As of 0.14.0 this can be 'setup', 'active', 'completed', 'f= ailed' or You know, it would be even nicer to convert from an open-coded 'str' to a finite enum of valid strings; it would be self-documenting, and make it that much easier to guarantee the code doesn't add new states without documenting when they were added. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --f3xv60dG1Ol6VhAEEXNtQWgPd8BvTgwhk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTdij8AAoJEKeha0olJ0NqyKcH/3Tky2iL+rRX0dU0gyOnzt0F N7apwxqo7jQ2D/p+/tslZIXrRwKVzhkyUw4eFI6pLdKfgvfeJWTfYnrQAyR6k4SX tuWhJnSpyN2C4D/eyUzDLniQrgIIuLiL/PbYuuh5kursrbYtrUInY1CyVfzMeuaT FthTv5NvzlFrXkKtPhOfLxBVsZ784h44YQH1MYC0z4CGAVGLeOrd+yBNA7yPIVHk cWmz1fYIW/N6mhdm0amVHKtC9y+5rZw8eILFB00jf85G7doG8pXtJx4b4KeBjrGI zOQGvC3TenMCRHXbjfjIGWOiYv456XJqJXvZM5THWEzUvGpb3nDFS0BbYa8/VmM= =Came -----END PGP SIGNATURE----- --f3xv60dG1Ol6VhAEEXNtQWgPd8BvTgwhk--