From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlL0z-000301-74 for qemu-devel@nongnu.org; Fri, 16 May 2014 12:29:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WlL0t-0002yM-67 for qemu-devel@nongnu.org; Fri, 16 May 2014 12:29:45 -0400 Received: from cantor2.suse.de ([195.135.220.15]:60705 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlL0s-0002y9-SV for qemu-devel@nongnu.org; Fri, 16 May 2014 12:29:39 -0400 Message-ID: <53763CF0.8070106@suse.de> Date: Fri, 16 May 2014 18:29:36 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1398876525-28831-1-git-send-email-ehabkost@redhat.com> <1398876525-28831-15-git-send-email-ehabkost@redhat.com> <53751931.4000503@suse.de> <20140515202626.GX3302@otherpad.lan.raisama.net> <53753BC2.1090604@suse.de> <20140516161305.GJ30616@otherpad.lan.raisama.net> In-Reply-To: <20140516161305.GJ30616@otherpad.lan.raisama.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 14/18] target-i386: Add "migratable" property to "host" CPU model List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Marcelo Tosatti , qemu-devel@nongnu.org, Paolo Bonzini , Igor Mammedov , Aurelien Jarno , Richard Henderson Am 16.05.2014 18:13, schrieb Eduardo Habkost: > On Fri, May 16, 2014 at 12:12:18AM +0200, Andreas F=E4rber wrote: >> Am 15.05.2014 22:26, schrieb Eduardo Habkost: >>> On Thu, May 15, 2014 at 09:44:49PM +0200, Andreas F=E4rber wrote: >>>> Am 30.04.2014 18:48, schrieb Eduardo Habkost: >>>>> This flag will allow the user to choose between two modes: >>>>> * All flags that can be enabled on the host, even if unmigratable >>>>> (migratable=3Dno); >>>>> * All flags that can be enabled on the host, known to QEMU, >>>>> and migratable (migratable=3Dyes). >>>>> >>>>> The default is still migratable=3Dfalse, to keep current behavior, = but >>>>> this will be changed to migratable=3Dtrue by another patch. >>>>> >>>>> My plan was to support the "migratable" flag on all CPU classes, bu= t >>>>> have the default to "false" on all CPU models except "host". Howeve= r, >>>>> DeviceClass has no mechanism to allow a child class to have a diffe= rent >>>>> property default from the parent class yet, so by now only the "hos= t" >>>>> CPU model will support the "migratable" flag. >>>> >>>> Just set the new default in the derived type's instance_init? >>> >>> That would work. I am still assuming that one day we will allow >>> management to query for class property defaults without instantiating >>> objects. But even if we do it, "host" is already an exception (becaus= e >>> the defaults depend on KVM initialization), so in this case it will b= e >>> OK. >>> >>> So, this patch can be dropped because it will be replaced. I will als= o >>> implement the other changes you requested for this patch. >> >> Before you make yourself too much work, have a peek at qom-cpu. :) >> I should have all except 15 and 18, with some cleanups TBD. >=20 > Thsnk! But I see two problems on current qom-cpu: >=20 > * The "migratable" flag is now not affecting the results of "-cpu host= " > (host_x86_cpu_initfn()), which was the whole point of adding the > property. Where did I break that? Renaming the variable and reordering it with a comment shouldn't be a functional change... Note that some patches needed to be applied with patch -p1 due to rebased qom-next, so maybe there's a mismerge somewhere? OTOH maybe we should start writing qtests for the CPU? I've been meaning to write one for cpu-add but didn't get to it yet. Andreas > * Without setting migratable=3Dyes by default, we are going to break > existing setups after applying 'support "invariant tsc" flag' and > "block migration and savevm if invariant tsc is exposed" (See > http://marc.info/?l=3Dqemu-devel&m=3D139838802220184&w=3D2 ). --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg