From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WlN1Q-0008J1-U2 for qemu-devel@nongnu.org; Fri, 16 May 2014 14:38:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WlN1J-0007aV-Eh for qemu-devel@nongnu.org; Fri, 16 May 2014 14:38:20 -0400 Message-ID: <53765B10.6050506@suse.de> Date: Fri, 16 May 2014 20:38:08 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1399473780-20374-1-git-send-email-marcel.a@redhat.com> <1399473780-20374-2-git-send-email-marcel.a@redhat.com> <20140516182011.5f3a3286@thinkpad> In-Reply-To: <20140516182011.5f3a3286@thinkpad> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/4] machine: conversion of QEMUMachineInitArgs to MachineState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , Marcel Apfelbaum Cc: mst@redhat.com, aik@ozlabs.ru, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, jcmvbkbc@gmail.com, edgar.iglesias@gmail.com, gxt@mprc.pku.edu.cn, proljc@gmail.com, agraf@suse.de, scottwood@freescale.com, borntraeger@de.ibm.com, hpoussin@reactos.org, aliguori@amazon.com, lersek@redhat.com, chouteau@adacore.com, jan.kiszka@web.de, stefanha@redhat.com, pbonzini@redhat.com, cornelia.huck@de.ibm.com, lcapitulino@redhat.com, peter.crosthwaite@xilinx.com, mark.langsdorf@calxeda.com, armbru@redhat.com, michael@walle.cc, qemu-ppc@nongnu.org, peter.chubb@nicta.com.au, aurelien@aurel32.net Am 16.05.2014 18:20, schrieb Igor Mammedov: > On Wed, 7 May 2014 17:42:57 +0300 > Marcel Apfelbaum wrote: >=20 >> Total removal of QEMUMachineInitArgs struct. QEMUMachineInitArgs's fie= lds >> are copied into MachineState. Removed duplicated fields from MachineSt= ate. >> >> All the other changes are only mechanical refactoring, no semantic cha= nges. >> >> Signed-off-by: Marcel Apfelbaum >> --- >> - I am perfectly aware that patches touching a lot of files >> are not desirable, but this one is a very simple replacement >> patch: >> QEMUMachineInitArgs -> MachineState >> args -> ms >> - This is the simplest way to get rid of QEMUMachineInitArgs fast. >> > One more thing: > pc_q35_init() and pc_init1() both use qdev_get_machine() for adding > properties. Please replace it with passed in machine. For the previous series we had clarified that qdev_get_machine() can safely be used. The benefit of passing "machine" would be efficiency of machine init only, so let's just do that as a follow-up cleanup please. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg